Skip to content

Updated exchange_rate sample dapps for transform with context. #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 7, 2022
Merged

Updated exchange_rate sample dapps for transform with context. #357

merged 6 commits into from
Nov 7, 2022

Conversation

@qj-yu
Copy link
Contributor

@qj-yu qj-yu commented Oct 25, 2022 •
edited
Loading

Overview
Updating "exchange_rate" sample dapps to be compatible with transform context for http_request feature.

Considerations

  • Hold on merging this PR until CDK v0.6.5 and DFX v0.12.0-beta6 are published.
  • Sample dapp should be re-deployed onto mainnet after IC release.

@qj-yu qj-yu requested a review from a team as a code owner October 25, 2022 05:29
@qj-yu qj-yu changed the title Updated exchange_rate sample dapps for transform with context. #NOT READY# Updated exchange_rate sample dapps for transform with context. Oct 25, 2022
@qj-yu qj-yu changed the title #NOT READY# Updated exchange_rate sample dapps for transform with context. #Do not merge before CDK 0.6.2 release# Updated exchange_rate sample dapps for transform with context. Oct 25, 2022
@qj-yu qj-yu changed the title #Do not merge before CDK 0.6.2 release# Updated exchange_rate sample dapps for transform with context. Updated exchange_rate sample dapps for transform with context. Nov 7, 2022
@qj-yu qj-yu merged commit 8ce92f0 into master Nov 7, 2022
@qj-yu qj-yu deleted the transform_context branch November 7, 2022 18:29
ericswanson-dfinity added a commit to dfinity/sdk that referenced this pull request Jun 8, 2023
@ericswanson-dfinity
test: update canister_http test for transform with context
376a997 
See also: dfinity/examples#357
@ericswanson-dfinity ericswanson-dfinity mentioned this pull request Jun 8, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krpeacock krpeacock krpeacock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qj-yu @krpeacock