Skip to content

Conversation

@maksymar
Copy link
Contributor

@maksymar maksymar commented May 9, 2025

This PR updates CI to use canbench v0.1.12.

CSV report in google sheets.
Minor changes in measurements probably due to canbench changes in between versions 0.1.11 and 0.1.12.

Known issue

@github-actions
Copy link

github-actions bot commented May 9, 2025

canbench 🏋 (dir: .) ceed723 2025-05-13 11:48:07 UTC

ℹ️ No significant performance changes detected 👍
./canbench_results.yml is up to date


---------------------------------------------------

Summary:
  instructions:
    counts:   [total 124 | new 0 | improved 4 | regressed 1 | unchanged 119] 🟢🔴
    change:   [min -41.08 M | med -45.30 K | max +10.20 M]
    change %: [min -2.90% | med -0.01% | max +2.95%]

  heap_increase:
    counts:   [total 124 | new 0 | improved 0 | regressed 1 | unchanged 123] 🔴
    change:   [min 0 | med 0 | max +1]
    change %: [min 0.00% | med 0.00% | max 0.00%]

  stable_memory_increase:
    counts:   [total 124 | new 0 | improved 0 | regressed 0 | unchanged 124]
    change:   [min 0 | med 0 | max 0]
    change %: [min 0.00% | med 0.00% | max 0.00%]

---------------------------------------------------

@maksymar maksymar changed the title ci: post only canbench summary as github comment ci: update canbench to post summary only, hide detailed results May 12, 2025
@maksymar maksymar changed the title ci: update canbench to post summary only, hide detailed results ci: update canbench to post summary with link to full CSV results May 12, 2025
@maksymar maksymar changed the title ci: update canbench to post summary with link to full CSV results ci: update canbench to post short summary with link to full CSV results May 12, 2025
maksymar added a commit to dfinity/canbench that referenced this pull request May 13, 2025
This PR fixes #106 by moving
results analysis fully into the canbench binary, removing it from the
run script.

Changes:
- Uploads CSV report as a job artifact and links it in the summary
report
- Adds explicit status into metric summary
- Removes empty first line from the report output
- Fills empty cells in the CSV report


![image](https://github.com/user-attachments/assets/4b2aa012-f003-4e87-853f-e9f786a80fc7)

Tested on [stable-structures PR
#301](dfinity/stable-structures#301).
@maksymar maksymar changed the base branch from main to maksym/persist May 13, 2025 09:10
Base automatically changed from maksym/persist to main May 13, 2025 09:18
@maksymar maksymar changed the title ci: update canbench to post short summary with link to full CSV results ci: update canbench to 0.1.12 May 13, 2025
@maksymar maksymar marked this pull request as ready for review May 13, 2025 11:52
@maksymar maksymar requested a review from a team as a code owner May 13, 2025 11:52
@maksymar maksymar requested a review from mraszyk May 13, 2025 11:52
@maksymar maksymar enabled auto-merge (squash) May 13, 2025 12:05
@maksymar maksymar merged commit 06add50 into main May 13, 2025
15 checks passed
@maksymar maksymar deleted the maksym/summary branch May 13, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants