-
Notifications
You must be signed in to change notification settings - Fork 34
ci: update canbench to 0.1.12 #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maksymar
added a commit
to dfinity/canbench
that referenced
this pull request
May 13, 2025
This PR fixes #106 by moving results analysis fully into the canbench binary, removing it from the run script. Changes: - Uploads CSV report as a job artifact and links it in the summary report - Adds explicit status into metric summary - Removes empty first line from the report output - Fills empty cells in the CSV report  Tested on [stable-structures PR #301](dfinity/stable-structures#301).
mraszyk
reviewed
May 13, 2025
mraszyk
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CI to use canbench v0.1.12.
CSV report in google sheets.
Minor changes in measurements probably due to canbench changes in between versions 0.1.11 and 0.1.12.
Known issue
canbenchbinary and posting scripts canbench#106