-
Notifications
You must be signed in to change notification settings - Fork 34
refactor: rename FixedVec to UnboundedVecN #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the code by renaming the FixedVec type to UnboundedVecN and updates all corresponding references in both the storable module and benchmark tests.
- Renamed FixedVec to UnboundedVecN in src/storable.rs with an updated doc comment.
- Updated all type aliases and function calls in benchmark files to reflect the new naming.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/storable.rs | Renamed the FixedVec type to UnboundedVecN and updated docs. |
| benchmarks/src/common.rs | Updated import statements to use UnboundedVecN. |
| benchmarks/btreemap/src/main.rs | Replaced all FixedVec aliases and invocations with UnboundedVecN equivalents. |
Comments suppressed due to low confidence (2)
src/storable.rs:193
- [nitpick] The new type name 'UnboundedVecN' might be misleading since the vector's length is enforced to be N. Consider revising the documentation or evaluating if the naming aligns with the intended semantics.
/// Unbounded vector of bytes, always of length `N`.
benchmarks/btreemap/src/main.rs:23
- Ensure that all type aliases and related benchmark references have been correctly updated to 'UnboundedVecN' and that their usage is consistent with the new naming convention.
type UnboundedVecN4 = UnboundedVecN<4>;
This PR refactors the code by renaming the
FixedVectype toUnboundedVecNand updates all corresponding references in both the storable module and benchmark tests.