Skip to content

Conversation

@maksymar
Copy link
Contributor

@maksymar maksymar commented Jun 5, 2025

This PR refactors the internal storage of BTreeMap nodes by renaming the keys_and_encoded_values field to entries and updating all related references across versioned implementations.

@maksymar maksymar requested a review from Copilot June 5, 2025 08:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the internal storage of BTreeMap nodes by renaming the keys_and_encoded_values field to entries and updating all related references across versioned implementations.

  • Rename keys_and_encoded_values to entries in node.rs, node/v1.rs, and node/v2.rs
  • Update loops, asserts, methods, and struct initializers to use entries

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/btreemap/node/v2.rs Renamed keys_and_encoded_values to entries and updated related loops and struct fields in V2
src/btreemap/node/v1.rs Renamed keys_and_encoded_values to entries and updated related loops and struct fields in V1
src/btreemap/node.rs Renamed struct field and all method accesses from keys_and_encoded_values to entries
Comments suppressed due to low confidence (1)

src/btreemap/node/v2.rs:153

  • EAGER_LOAD_KEY_SIZE_THRESHOLD is defined but never used; consider removing this constant or applying it to gate eager key loading logic.
const EAGER_LOAD_KEY_SIZE_THRESHOLD: u32 = 16;

@maksymar maksymar marked this pull request as ready for review June 5, 2025 08:06
@maksymar maksymar requested a review from a team as a code owner June 5, 2025 08:06
@maksymar maksymar enabled auto-merge (squash) June 5, 2025 08:06
@maksymar maksymar disabled auto-merge June 5, 2025 08:06
@maksymar maksymar enabled auto-merge (squash) June 5, 2025 08:09
@maksymar maksymar merged commit 52f7388 into main Jun 5, 2025
17 checks passed
@maksymar maksymar deleted the maksym/entries branch June 5, 2025 08:14
@github-actions
Copy link

github-actions bot commented Jun 5, 2025

canbench 🏋 (dir: ./benchmarks/vec) 4957a42 2025-06-05 08:11:00 UTC

./benchmarks/vec/canbench_results.yml is up to date
📦 canbench_results_vec.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes detected 👍
    counts:   [total 16 | new 0 | improved 0 | regressed 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes detected 👍
    counts:   [total 16 | new 0 | improved 0 | regressed 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes detected 👍
    counts:   [total 16 | new 0 | improved 0 | regressed 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

canbench 🏋 (dir: ./benchmarks/memory_manager) 4957a42 2025-06-05 08:10:53 UTC

./benchmarks/memory_manager/canbench_results.yml is up to date
📦 canbench_results_memory-manager.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes detected 👍
    counts:   [total 3 | new 0 | improved 0 | regressed 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes detected 👍
    counts:   [total 3 | new 0 | improved 0 | regressed 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes detected 👍
    counts:   [total 3 | new 0 | improved 0 | regressed 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

canbench 🏋 (dir: ./benchmarks/btreemap) 4957a42 2025-06-05 08:12:41 UTC

./benchmarks/btreemap/canbench_results.yml is up to date
📦 canbench_results_btreemap.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes detected 👍
    counts:   [total 285 | new 0 | improved 0 | regressed 0 | unchanged 285]
    change:   [max +269.56K | p75 0 | median 0 | p25 0 | min -1.03M]
    change %: [max +0.06% | p75 0.00% | median 0.00% | p25 0.00% | min -0.17%]

  heap_increase:
    status:   No significant changes detected 👍
    counts:   [total 285 | new 0 | improved 0 | regressed 0 | unchanged 285]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes detected 👍
    counts:   [total 285 | new 0 | improved 0 | regressed 0 | unchanged 285]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

canbench 🏋 (dir: ./benchmarks/compare) 4957a42 2025-06-05 08:11:47 UTC

./benchmarks/compare/canbench_results.yml is up to date
📦 canbench_results_compare.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes detected 👍
    counts:   [total 18 | new 0 | improved 0 | regressed 0 | unchanged 18]
    change:   [max +53.05M | p75 0 | median 0 | p25 0 | min -8.77K]
    change %: [max +0.06% | p75 0.00% | median 0.00% | p25 0.00% | min -0.00%]

  heap_increase:
    status:   No significant changes detected 👍
    counts:   [total 18 | new 0 | improved 0 | regressed 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes detected 👍
    counts:   [total 18 | new 0 | improved 0 | regressed 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants