-
Couldn't load subscription status.
- Fork 34
refactor: improve naming of BTreeMap inner key/value storage #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the internal storage of BTreeMap nodes by renaming the keys_and_encoded_values field to entries and updating all related references across versioned implementations.
- Rename
keys_and_encoded_valuestoentriesinnode.rs,node/v1.rs, andnode/v2.rs - Update loops, asserts, methods, and struct initializers to use
entries
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/btreemap/node/v2.rs | Renamed keys_and_encoded_values to entries and updated related loops and struct fields in V2 |
| src/btreemap/node/v1.rs | Renamed keys_and_encoded_values to entries and updated related loops and struct fields in V1 |
| src/btreemap/node.rs | Renamed struct field and all method accesses from keys_and_encoded_values to entries |
Comments suppressed due to low confidence (1)
src/btreemap/node/v2.rs:153
- EAGER_LOAD_KEY_SIZE_THRESHOLD is defined but never used; consider removing this constant or applying it to gate eager key loading logic.
const EAGER_LOAD_KEY_SIZE_THRESHOLD: u32 = 16;
|
|
|
|
This PR refactors the internal storage of
BTreeMapnodes by renaming thekeys_and_encoded_valuesfield toentriesand updating all related references across versioned implementations.