Skip to content

chore: Revert "chore(deps): bump slackapi/slack-github-action from 1.25.0 to 2.1.1" #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

chore: Revert "chore(deps): bump slackapi/slack-github-action from 1.25.0 to 2.1.1" #384

merged 1 commit into from
Aug 15, 2025

Conversation

@maksymar
Copy link
Contributor

Reverts #373

this version bump breaks CI:

Warning: Unexpected input(s) 'channel-id', 'slack-message', valid inputs are ['api', 'errors', 'method', 'payload', 'payload-delimiter', 'payload-file-path', 'payload-templated', 'proxy', 'retries', 'token', 'webhook', 'webhook-type']
Run slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a
Error: Missing input! Either a method or webhook is required to take action.
SlackError: Missing input! Either a method or webhook is required to take action.
    at Config.validate (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/config.js:193:1)
    at new Config (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/config.js:124:1)
    at send (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/send.js:13:1)
    at file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/index.js:9:1
    at Function.__nccwpck_require__.a (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/webpack/runtime/async module:49:1)
    at Object.9722 (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/dist/index.js:45875:21)
    at __nccwpck_require__ (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/webpack/bootstrap:21:1)
    at file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/webpack/startup:4:1
    at ModuleJob.run (node:internal/modules/esm/module_job:263:25)
    at ModuleLoader.import (node:internal/modules/esm/loader:540:24)

file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/config.js:193
        throw new SlackError(
^
SlackError: Missing input! Either a method or webhook is required to take action.
    at Config.validate (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/config.js:193:1)
    at new Config (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/config.js:124:1)
    at send (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/send.js:13:1)
    at file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/src/index.js:9:1
    at Function.__nccwpck_require__.a (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/webpack/runtime/async module:49:1)
    at Object.9722 (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/dist/index.js:45875:21)
    at __nccwpck_require__ (file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/webpack/bootstrap:21:1)
    at file:///home/runner/work/_actions/slackapi/slack-github-action/91efab103c0de0a537f72a35f6b8cda0ee76bf0a/webpack/startup:4:1
    at ModuleJob.run (node:internal/modules/esm/module_job:263:25)
    at ModuleLoader.import (node:internal/modules/esm/loader:540:24)

@maksymar maksymar marked this pull request as ready for review August 15, 2025 08:56
@maksymar maksymar requested a review from a team as a code owner August 15, 2025 08:56
@maksymar maksymar changed the title Revert "chore(deps): bump slackapi/slack-github-action from 1.25.0 to 2.1.1" chore: Revert "chore(deps): bump slackapi/slack-github-action from 1.25.0 to 2.1.1" Aug 15, 2025
@maksymar maksymar enabled auto-merge (squash) August 15, 2025 08:57
@maksymar maksymar merged commit d55e319 into main Aug 15, 2025
17 of 19 checks passed
@maksymar maksymar deleted the revert-373-dependabot/github_actions/slackapi/slack-github-action-2.1.1 branch August 15, 2025 09:09
@github-actions
Copy link

canbench 🏋 (dir: ./benchmarks/nns) 8462d4f 2025-08-15 09:05:29 UTC

✅ ./benchmarks/nns/canbench_results.yml is up to date
📦 canbench_results_nns.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median -98 | p25 -439.05K | min -6.98M]
    change %: [max 0.00% | p75 0.00% | median -0.04% | p25 -0.16% | min -0.29%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link

canbench 🏋 (dir: ./benchmarks/memory_manager) 8462d4f 2025-08-15 09:05:17 UTC

✅ ./benchmarks/memory_manager/canbench_results.yml is up to date
📦 canbench_results_memory-manager.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link

canbench 🏋 (dir: ./benchmarks/btreemap) 8462d4f 2025-08-15 09:07:06 UTC

✅ ./benchmarks/btreemap/canbench_results.yml is up to date
📦 canbench_results_btreemap.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 303 | regressed 0 | improved 0 | new 0 | unchanged 303]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 303 | regressed 0 | improved 0 | new 0 | unchanged 303]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 303 | regressed 0 | improved 0 | new 0 | unchanged 303]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link

canbench 🏋 (dir: ./benchmarks/vec) 8462d4f 2025-08-15 09:05:23 UTC

✅ ./benchmarks/vec/canbench_results.yml is up to date
📦 canbench_results_vec.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link

canbench 🏋 (dir: ./benchmarks/io_chunks) 8462d4f 2025-08-15 09:06:01 UTC

✅ ./benchmarks/io_chunks/canbench_results.yml is up to date
📦 canbench_results_io_chunks.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions
Copy link

canbench 🏋 (dir: ./benchmarks/btreeset) 8462d4f 2025-08-15 09:05:30 UTC

✅ ./benchmarks/btreeset/canbench_results.yml is up to date
📦 canbench_results_btreeset.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@maksymar maksymar mentioned this pull request Aug 19, 2025
Merged
maksymar added a commit that referenced this pull request Aug 19, 2025
@maksymar
ci: fix slackapi v2.1.1 (#389)
07032a2 
This PR tries to properly migrate from v1.25.0 to v2.1.1.

Previous attempt #384
got reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berestovskyy berestovskyy berestovskyy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maksymar @berestovskyy