Replace FarmHash with AESHash for Oracle conflicts #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are using FarmHash to resolve conflicts in Oracle. This commit replaces FarmHash with AESHash. AESHash has been implemented in runtime package. It performs better than FarmHash.
ashish-goswami
requested review from
a team,
jarifibrahim,
manishrjain and
poonai
manishrjain
approved these changes
Jul 31, 2019
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim and @Sch00lb0y)
jarifibrahim
approved these changes
Aug 1, 2019
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 9, 2019
Currently we are using FarmHash to resolve conflicts in Oracle. This commit replaces FarmHash with AESHash. AESHash has been implemented in runtime package. It performs better than FarmHash.
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
Currently we are using FarmHash to resolve conflicts in Oracle. This commit replaces FarmHash with AESHash. AESHash has been implemented in runtime package. It performs better than FarmHash. (cherry picked from commit 7372ede)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are using FarmHash to resolve conflicts in
Oracle. This commit replaces FarmHash with AESHash. AESHash
has been implemented in runtime package. It performs better
than FarmHash.
This change is