Fix race condition in updateDiscardStats #973
Conversation
The TestGetMore test fails with race condition in updateDiscardStats function. See https://teamcity.dgraph.io/viewLog.html?buildId=19032&buildTypeId=Badger_UnitTests
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@jarifibrahim you can click here to see the review status or cancel the code review job.
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
This change expands the critical area for the entire body of the function as opposed to unlocking the vlog stats resource after all the stats have been consumed.
Using the atomic package it could provide an easier to reason about guard against race conditions and reduce the size of the critical area between the semaphore. See: https://golang.org/pkg/sync/atomic/#AddInt64
Reviewed with ❤️ by PullRequest
The TestGetMore test fails with race condition in updateDiscardStats function. See https://teamcity.dgraph.io/viewLog.html?buildId=19032&buildTypeId=Badger_UnitTests (cherry picked from commit 0283a03)
The TestGetMore test fails with race condition in updateDiscardStats
function.
See https://teamcity.dgraph.io/viewLog.html?buildId=19032&buildTypeId=Badger_UnitTests
This change is