Make semantic integrity check insensitive to field order #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as standardized in dhall-lang/dhall-lang#223 Fixes #548 This changes β-normalization to sort fields so that semantic integrity checks don't change when reordering fields
f-f
approved these changes
Aug 25, 2018
The Nix build sets `HOME=/homeless-shelter`, which leads to a test failure
since the test tries to create a "${HOME}/.cache" directory without first
checking if "${HOME}" is accessible. This changes the `assertDirectory`
function to recursively check parent directories to avoid this issue, which
in turn fixes the test (since it gracefully creates no directories if none are
accessible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as standardized in dhall-lang/dhall-lang#223
Fixes #548
This changes β-normalization to sort fields so that semantic integrity
checks don't change when reordering fields