Skip to content

Fix error message for not-equal when type checking #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2018
Merged

Fix error message for not-equal when type checking #768

merged 1 commit into from
Dec 28, 2018

Conversation

@basile-henry
Copy link
Collaborator

@basile-henry basile-henry commented Dec 28, 2018

According to the standard https://github.com/dhall-lang/dhall-lang/blob/master/standard/dhall.abnf\#L399 the correct operator is !=

Here is an example of the error message:

⊢ 2 != 3

Error: ❰/=❱ only works on ❰Bool❱s

2 != 3
(stdin):1:1

@basile-henry basile-henry self-assigned this Dec 28, 2018
@Gabriella439 Gabriella439 merged commit 528ea42 into dhall-lang:master Dec 28, 2018
@basile-henry basile-henry deleted the basile/not-equal-err-msg branch December 28, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

Assignees

@basile-henry basile-henry

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@basile-henry @Gabriella439