test: improve coverage for delete operation #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobjolliffe
approved these changes
Apr 6, 2023
bobjolliffe
left a comment
bobjolliffe
left a comment
There was a problem hiding this comment.
RemoteDhis2Exception is an interesting class, adding the http status code. I guess this is to catch exceptions at the transport/http level. The sdk will always be dealing with remote DHIS2. Maybe a name like DHIS2TransportException or DHIS2HttpException might be a little more accurate. But it is nit picking :-)
Collaborator
Author
Actually it's called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.