Skip to content

chore(package.json): fix repository urls#402

Merged
3 commits merged intomasterfrom
fix-npm-repo
Dec 8, 2020
Merged

chore(package.json): fix repository urls#402
3 commits merged intomasterfrom
fix-npm-repo

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 8, 2020

Our repo urls in package.json were incorrect. Changed them to the new location.

@ghost ghost self-requested a review December 8, 2020 10:24
@cypress
Copy link
Copy Markdown

cypress Bot commented Dec 8, 2020



Test summary

495 0 0 0


Run details

Project ui
Status Passed
Commit adc754c
Started Dec 8, 2020 11:17 AM
Ended Dec 8, 2020 11:20 AM
Duration 03:38 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Copy Markdown
Contributor

@Mohammer5 Mohammer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add the "folder" property to the "repository", like so:

{
  "respository": {
    "type": "git",
    "url": "https://github.com/dhis2/ui.git",
    "folder": "packages/core"
  }
}

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 8, 2020

We could also add the "folder" property to the "repository", like so:

{
  "respository": {
    "type": "git",
    "url": "https://github.com/dhis2/ui.git",
    "folder": "packages/core"
  }
}

I see in the npm docs that they recommend a "directory" key for that. Do you mean that, or is the "folder" key something else? https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 8, 2020

@Mohammer5 I've added the directory keys. Seems like a nice addition 👍

@ghost ghost requested a review from Mohammer5 December 8, 2020 11:02
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 8, 2020

We could actually also add homepage and bugs, what do you think?

Copy link
Copy Markdown
Contributor

@Mohammer5 Mohammer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Seems like I somehow thought it was "folder" when it's actually "directory", so your changes are 100% correct

@ghost ghost merged commit 8a947df into master Dec 8, 2020
@ghost ghost deleted the fix-npm-repo branch December 8, 2020 11:23
@dhis2-bot
Copy link
Copy Markdown
Contributor

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants