Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Mohammer5
left a comment
There was a problem hiding this comment.
We could also add the "folder" property to the "repository", like so:
{
"respository": {
"type": "git",
"url": "https://github.com/dhis2/ui.git",
"folder": "packages/core"
}
}
I see in the npm docs that they recommend a "directory" key for that. Do you mean that, or is the "folder" key something else? https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository |
|
@Mohammer5 I've added the directory keys. Seems like a nice addition 👍 |
Mohammer5
left a comment
There was a problem hiding this comment.
LGTM.
Seems like I somehow thought it was "folder" when it's actually "directory", so your changes are 100% correct
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Our repo urls in package.json were incorrect. Changed them to the new location.