Timelines are deleted if folders are nested too far

[zaknafean]

The problem

Describe the bug
When moving subfolders into one another, timelines are deleted if the nesting goes too far. The timelines no longer exist within the Godot file system or the Windows Explorer.

To Reproduce
Steps to reproduce the behavior:

1. Create 3 folder with a timeline in each. /A, /B, /C with timelines tA, tB, tC
2. Move folder /A into folder /B. /B/A/tA and /B/tB are fine
3. Move folder /C into folder /A. /B/A/tA and /B/tB are fine, but /B/A/C/tC no longer exists

Attached below is an animated Gif demonstrating the problem

Expected behavior
I would ideally expect the folder rearrangement to just happen. If thats not possible an error message. Bare minimum I'd like the timelines to not be deleted, so I can still use them rather than have to recreate them all from scratch.

Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

• OS: Windows
• Godot Version: 3.3
• Dialogic Version: 1.2.5

Solutions

Workaround
You can move folders up to 2 deep without issue. So Timeline/FirstFolder/SecondFolder is fine but Timeline/FirstFolder/SecondFolder/ThirdFolder is bad. Interestingly you can successfully CREATE a timeline in that hypothetical ThirdFolder without much issue. Its only the moving of the subfolders that seems to break.

Possible fixes
Possible fixes for this are beyond my skill in coding.

[zaknafean]

I think I found the issue, thankfully seemed pretty simple.
First to redefine the root problem: Moving a folder with subfolder to a different root folder, will result in all files in all subfolders being deleted. Or if you put a move-folder with sub-folders into a new root-folder, all files in sub-folders will be deleted.

Line 202-203 of DialogicUtil is a recursive call dealing with removing folders within folders in the remove_folder function, and is called by the the move_folder_to_folder function.

Notably this remove_folder function takes an argument to delete files, and naturally move_folder_to_folder passes a false here. Unfortunately the recursive call defaults to true, and that seems to be the source of the bug. All sub folders in the folder being moved wipe out the files recursively. I don't think this was intended.

The simple fix is to simply pass along the delete_files argument to the recursive remove_folder call. Thus if you don't want to delete the files in the parent folder, you don't delete the files in the child folders, and if you do want them gone, they also go.

I've made the change and pull request. It definitely fixes my case, but I may be missing some other use case for remove_folder that makes my change wrong, so a couple more eyes would be helpful.

#408

[coppolaemilio]

thank you for the PR! I'll review it and merge it asap 👍🏻

[zaknafean]

Looks all good to me!