Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out the Counting Quotient Filter as a replacement? for Bloom filter/CMS. #1667

Closed
wants to merge 1 commit into from

Conversation

ctb
Copy link
Member

@ctb ctb commented Apr 5, 2017

Ref #1665 (comment).

Current status: this compiles on Titus's laptop, but no CQF code is yet used :)

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

@luizirber
Copy link
Member

Show we try this as a scihack? dib-lab/scihack#2

@standage
Copy link
Member

standage commented Apr 5, 2017

Show we try this as a scihack?

I'm down. Might not garner interest from everybody, but it's important enough to a lot of things we do in the lab.

@ctb
Copy link
Member Author

ctb commented Apr 5, 2017 via email

@betatim
Copy link
Member

betatim commented Apr 17, 2017

I'll make an attempt at building a Storage based on this branch tomorrow unless someone else gets to it first.

@betatim betatim mentioned this pull request Apr 18, 2017
8 tasks
@standage
Copy link
Member

Closing in favor of #1675.

@standage standage closed this Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants