Cascade Delete should delete files

[Ashgar225]

I appreciate the existence of the new cascade delete feature, but it seems incomplete. I expected it to delete the files in the folder, not unlink them, in almost all of my folders that's functionally identical to moving them to the parent folder. The big red warning seems wildly out of place for the current functionality.

Thanks to the folder refactor you now can delete all of the files in a folder from the folder view, but I unfortunately deleted most of my folders before I figured out that this didn't work the way I expected.

[diced]

the warning is there to prevent what you did..? if you didn't read it correctly how does that make it incomplete or out of place..

[Ashgar225]

While the warning is accurate (and why this is not a bug), my expectation was that an option called "cascade delete" would function like "rm -r". My hope is that it would delete the files in the folder, not just the folder itself. It even says "delete everything" and it very much does not do that.

[Benzeel]

this！
adding a second button below delete folder that says "delete folders and files" and updating the warning text or similar would be nice！

[mrpops2ko]

+1 for this, its a real pain that it doesn't delete all the files too. it would be nice if the option to delete all files included a blurb like deleting this folder will reclaim xxx.xx MiB space so its acutely obvious too

[Ashgar225]

And looks like this was confusing enough to generate a bug report, #1106 is a complaint about this functionality not working as expected.

[Benzeel]

this has changed ！
https://m.patchokki.art/m/WZi.png
it no longer says this (currently in the trunk release)

[Ashgar225]

As of v4.6.2, it still contains the message visible in this thread if you select "Cascade Delete", and still unlinks files instead of deleting them.

[Benzeel]

As of v4.6.2, it still contains the message visible in this thread if you select "Cascade Delete", and still unlinks files instead of deleting them.

best to wait till next release！

i am currently on trunk which is surprisingly stable.

[diced]

Added in 4329dc7

two options now, one that only removes folders, one that removes folders and files: