Issue 14/create invitation #21
Conversation
* allows specifying more oprtions that * are covered in SWAGGER but not in our code yet
* it only gets passed when provided * reflects the trith of the API where it is optional
morrieinmaas
force-pushed
the
issue_14/create_invitation
branch
from
4d901b6 to
58bff38
Compare
morrieinmaas
changed the title
|
@wip-abramson please have a quick look and see whether that addresses all points appropriate. Let me know if not. Happy to make further changes. As you'll see what we discussed earlier today is implemented. |
| logger.debug(f"{connection_id} state updated") | ||
|
|
||
| # Combines receive and accept connection api calls | ||
| async def accept_connection(self, invitation): |
There was a problem hiding this comment.
Again this needs to be versioned change. To 0.2
| "service_endpoint": "http://192.168.56.102:8020" | ||
| } | ||
| """ | ||
| params['body'] = invite_options |
There was a problem hiding this comment.
Is this right? I don't think so.
I think this body should be sent as json_data
There was a problem hiding this comment.
Yeah good shout! Silly me. It's changed now.
|
This looks good. Few minor things. See comments above. Did you test the json.dumps for params btw? |
| # Store a received credential | ||
| async def store_credential(self, cred_ex_id, credential_id): | ||
| body = {"credential_id": credential_id} | ||
| async def store_credential(self, cred_ex_id, credential_id: str = None): |
There was a problem hiding this comment.
This should not be in this commit. It is also added in separate P.R. #21
There was a problem hiding this comment.
I'll address that
There was a problem hiding this comment.
@wip-abramson just looked at that and now I'm confused what you mean. The PR you referenced is this PR? Not sure what you mean now. Issue is 14 PR is 21. Happy to change however you like it, please, clarify though😅
morrieinmaas
force-pushed
the
issue_14/create_invitation
branch
from
04cf61d to
3fcf2aa
Compare
No description provided.