Change sending problem report so it #20
Conversation
morrieinmaas
commented
Apr 21, 2021
morrieinmaas
commented
- takes in an explanation string
- constructs the explanation reuqest json object
- uses the created object for the request
* takes in an explanation string * constructs the explanation reuqest json object * uses the created object for the request
| # Send a problem report for presentation exchange | ||
| async def send_problem_report(self, pres_ex_id, request): | ||
| async def send_problem_report(self, pres_ex_id, explanation: str): | ||
| explanation_request = {"explain_ltxt": explanation} |
There was a problem hiding this comment.
Don't know that this should be called explanation_request. Maybe just body even would be fine
There was a problem hiding this comment.
I've checked the code and the only other place regarding Problem_report is in issuer.py where there already is an explanation param that builds the body like that.
|
This is good, but we need to also fix this for issue-credential I believe. And maybe some other locations where we cause problem report to occur that I am not aware of. |
I'll have a look at that |
|
Actually, @wip-abramson , not sure what you mean/how this applies for issue-credential. Like I said above there is only two places |
|
@morrieinmaas you can include problem report into credential issuance for example to report back problems with the data. i.e. my name is spelt wrong as an example. |
* Including sending problem report when * issueing credentials fails
|
@lohanspies I've added problem reporting to issue_credentials in case that fails/catches an exception. |
* log message with stacktrace but also * raise it
