Skip to content

Conversation

tautschnig
Copy link
Collaborator

All Windows builds were failing to download clcache from nuget. This
problem also documented in
actions/runner-images#3240. Follow
their approach to fix the nuget setup.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

All Windows builds were failing to download clcache from nuget. This
problem also documented in
actions/runner-images#3240. Follow
their approach to fix the nuget setup.
@tautschnig tautschnig marked this pull request as ready for review April 23, 2021 14:24
@tautschnig tautschnig requested a review from a team as a code owner April 23, 2021 14:24
@tautschnig tautschnig mentioned this pull request Apr 23, 2021
7 tasks
@NlightNFotis
Copy link
Contributor

Hi Michael, thanks for this 👍🏻 I was also playing around with Nuget locally and I got the install instructions from CI working on my machine, which made it all the more confusing (same version 5.9.1)

@tautschnig
Copy link
Collaborator Author

Hi Michael, thanks for this 👍🏻 I was also playing around with Nuget locally and I got the install instructions from CI working on my machine, which made it all the more confusing (same version 5.9.1)

I was lazy and started digging through https://github.com/actions/virtual-environments/issues with the hope that we're not the only ones facing the problem :-)

@tautschnig tautschnig self-assigned this Apr 23, 2021
@NlightNFotis NlightNFotis merged commit 8a117bc into diffblue:develop Apr 23, 2021
@tautschnig tautschnig deleted the nuget branch April 23, 2021 16:41
NlightNFotis added a commit to NlightNFotis/cbmc that referenced this pull request Apr 29, 2021
Previously, we had an issue where the latest default version of
nuget in github actions was broken and couldn't install dependencies.
This was fixed (temporarily) by diffblue#6054 when the latest version
installed by setup-nuget was 5.8.1. This has now changed to also
install the bugged version (5.9.x) by default, giving us problems.

These are now solved by temporarily fixing the version of nuget
to a known working version (according to multiple reports online,
and evidence of our own CI logs).
@NlightNFotis NlightNFotis mentioned this pull request Apr 29, 2021
7 tasks
jezhiggins pushed a commit to jezhiggins/cbmc that referenced this pull request May 3, 2021
Previously, we had an issue where the latest default version of
nuget in github actions was broken and couldn't install dependencies.
This was fixed (temporarily) by diffblue#6054 when the latest version
installed by setup-nuget was 5.8.1. This has now changed to also
install the bugged version (5.9.x) by default, giving us problems.

These are now solved by temporarily fixing the version of nuget
to a known working version (according to multiple reports online,
and evidence of our own CI logs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants