Skip to content

Conversation

NlightNFotis
Copy link
Contributor

@NlightNFotis NlightNFotis commented Apr 29, 2021

Previously, we had an issue where the latest default version of
nuget in github actions was broken and couldn't install dependencies.
This was fixed (temporarily) by #6054 when the latest version
installed by setup-nuget was 5.8.1. This has now changed to also
install the bugged version (5.9.x) by default, giving us problems.

These are now solved by temporarily fixing the version of nuget
to a known working version (according to multiple reports online,
and evidence of our own CI logs).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Previously, we had an issue where the latest default version of
nuget in github actions was broken and couldn't install dependencies.
This was fixed (temporarily) by diffblue#6054 when the latest version
installed by setup-nuget was 5.8.1. This has now changed to also
install the bugged version (5.9.x) by default, giving us problems.

These are now solved by temporarily fixing the version of nuget
to a known working version (according to multiple reports online,
and evidence of our own CI logs).
@NlightNFotis NlightNFotis requested a review from tautschnig April 29, 2021 10:52
@NlightNFotis NlightNFotis requested a review from a team as a code owner April 29, 2021 10:52
@NlightNFotis NlightNFotis self-assigned this Apr 29, 2021
@NlightNFotis NlightNFotis merged commit 6157aae into diffblue:develop Apr 29, 2021
@NlightNFotis NlightNFotis deleted the fix-nuget-version branch April 29, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants