Verilog: move assignment conversion code #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test for function input ports that demonstrates that function input ports are assignment-like contexts.
The code for assignment conversions (1800-2017 10.8) is required for converting the arguments of function calls, and hence, when type checking expressions. This moves the code for assignment conversions from verilog_typecheck.cpp to verilog_typecheck_expr.cpp, and replaces the use of propagate_type by assignment_conversion. The propagate_type method is then no longer needed.
tautschnig
approved these changes
Oct 13, 2025
kroening
added a commit
that referenced
this pull request
Oct 17, 2025
This deletes the assignment conversion code from verilog_typecheck.cpp, which was omitted from #1318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for assignment conversions (1800-2017 10.8) is required for converting the arguments of function calls, and hence, when type checking expressions.
This moves the code for assignment conversions from verilog_typecheck.cpp to verilog_typecheck_expr.cpp, and replaces the use of
propagate_typebyassignment_conversion. Thepropagate_typemethod is then no longer needed.