SMV: catch variables that have the same identifier as a parameter #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
already_declared4-fix
branch
2 times, most recently
from
8631e09 to
ea60549
Compare
tautschnig
approved these changes
Nov 10, 2025
src/smvlang/smv_typecheck.cpp
Outdated
Comment on lines
2144
to
2147
| std::unordered_set<irep_idt, irep_id_hash> enums; | ||
|
|
||
| // to catch re-use of parameter identifiers | ||
| std::unordered_set<irep_idt> parameters; |
Collaborator
There was a problem hiding this comment.
I'd say both or none should use , irep_id_hash.
This errors variable and enum declarations that use the same identifier as a previously defined module parameter.
kroening
force-pushed
the
already_declared4-fix
branch
from
ea60549 to
daf9e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This errors variable and enum declarations that use the same identifier as a previously defined module parameter.