Skip to content

Pause polling when hidden #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminshafii merged 1 commit into from
Feb 3, 2026
Merged

Pause polling when hidden #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions packages/app/src/app/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,14 @@ export default function App() {
setOpenworkServerSettings(readOpenworkServerSettings());
});

createEffect(() => {
if (typeof document === "undefined") return;
const update = () => setDocumentVisible(document.visibilityState !== "hidden");
update();
document.addEventListener("visibilitychange", update);
onCleanup(() => document.removeEventListener("visibilitychange", update));
});

createEffect(() => {
const pref = startupPreference();
const info = openworkServerHostInfo();
Expand Down Expand Up @@ -339,6 +347,7 @@ export default function App() {

createEffect(() => {
if (typeof window === "undefined") return;
if (!documentVisible()) return;
const url = openworkServerBaseUrl().trim();
const auth = openworkServerAuth();
const token = auth.token;
Expand All @@ -353,6 +362,13 @@ export default function App() {

let active = true;
let busy = false;
let timeoutId: number | undefined;
let delayMs = 10_000;

const scheduleNext = () => {
if (!active) return;
timeoutId = window.setTimeout(run, delayMs);
};

const run = async () => {
if (busy) return;
Expand All @@ -362,23 +378,30 @@ export default function App() {
if (!active) return;
setOpenworkServerStatus(result.status);
setOpenworkServerCapabilities(result.capabilities);
delayMs =
result.status === "connected" || result.status === "limited"
? 10_000
: Math.min(delayMs * 2, 60_000);
} catch {
delayMs = Math.min(delayMs * 2, 60_000);
} finally {
if (!active) return;
setOpenworkServerCheckedAt(Date.now());
busy = false;
scheduleNext();
}
};

run();
const interval = window.setInterval(run, 10_000);
onCleanup(() => {
active = false;
window.clearInterval(interval);
if (timeoutId) window.clearTimeout(timeoutId);
});
});

createEffect(() => {
if (!isTauriRuntime()) return;
if (!documentVisible()) return;
let active = true;

const run = async () => {
Expand All @@ -400,6 +423,7 @@ export default function App() {

createEffect(() => {
if (typeof window === "undefined") return;
if (!documentVisible()) return;
if (!developerMode()) {
setOpenworkServerDiagnostics(null);
return;
Expand Down Expand Up @@ -438,6 +462,7 @@ export default function App() {
createEffect(() => {
if (!isTauriRuntime()) return;
if (!developerMode()) return;
if (!documentVisible()) return;

let busy = false;

Expand All @@ -464,6 +489,7 @@ export default function App() {
setOwpenbotInfoState(null);
return;
}
if (!documentVisible()) return;

let active = true;

Expand All @@ -490,6 +516,7 @@ export default function App() {
setOpenwrkStatusState(null);
return;
}
if (!documentVisible()) return;

let active = true;

Expand Down Expand Up @@ -525,6 +552,7 @@ export default function App() {
const mountTime = Date.now();
const [lastKnownConfigSnapshot, setLastKnownConfigSnapshot] = createSignal("");
const [developerMode, setDeveloperMode] = createSignal(false);
const [documentVisible, setDocumentVisible] = createSignal(true);
let markReloadRequiredRef: (reason: ReloadReason, trigger?: ReloadTrigger) => void = () => {};
let setReloadLastFinishedAtRef: (value: number) => void = () => {};

Expand Down Expand Up @@ -1392,6 +1420,7 @@ export default function App() {
setDevtoolsWorkspaceId(null);
return;
}
if (!documentVisible()) return;

const client = devtoolsOpenworkClient();
if (!client) {
Expand Down Expand Up @@ -1430,6 +1459,7 @@ export default function App() {
setOpenworkAuditError(null);
return;
}
if (!documentVisible()) return;

const client = devtoolsOpenworkClient();
const workspaceId = devtoolsWorkspaceId();
Expand Down Expand Up @@ -2100,6 +2130,7 @@ export default function App() {

createEffect(() => {
if (typeof window === "undefined") return;
if (!documentVisible()) return;
if (openworkReloadUnsupported()) return;
const client = openworkServerClient();
const workspaceId = openworkServerWorkspaceId();
Expand Down
17 changes: 15 additions & 2 deletions packages/app/src/app/components/status-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ type StatusBarProps = {

export default function StatusBar(props: StatusBarProps) {
const [owpenbotStatus, setOwpenbotStatus] = createSignal<OwpenbotStatus | null>(null);
const [documentVisible, setDocumentVisible] = createSignal(true);

const opencodeStatusMeta = createMemo(() => ({
dot: props.clientConnected ? "bg-green-9" : "bg-gray-6",
Expand Down Expand Up @@ -162,12 +163,24 @@ export default function StatusBar(props: StatusBarProps) {
setOwpenbotStatus(next);
};

onMount(() => {
createEffect(() => {
if (typeof document === "undefined") return;
const update = () => setDocumentVisible(document.visibilityState !== "hidden");
update();
document.addEventListener("visibilitychange", update);
onCleanup(() => document.removeEventListener("visibilitychange", update));
});

createEffect(() => {
if (!documentVisible()) return;
refreshOwpenbot();
const interval = window.setInterval(refreshOwpenbot, 15_000);
onCleanup(() => window.clearInterval(interval));
});

onMount(() => {
scheduleTips(6_000);
onCleanup(() => {
window.clearInterval(interval);
if (tipTimer) window.clearTimeout(tipTimer);
if (tipHideTimer) window.clearTimeout(tipHideTimer);
});
Expand Down
Loading