Emphasize proper names in docs. #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edongashi
approved these changes
Nov 2, 2021
edongashi
reviewed
Nov 2, 2021
Comment on lines
+19
to
+27
| __Diffix for Desktop__ only accepts CSV files as input. | ||
|
|
||
| Diffix for Desktop interprets the first row of the CSV file as column names. | ||
| __Diffix for Desktop__ interprets the first row of the CSV file as column names. | ||
|
|
||
| Diffix for Desktop auto-detects the CSV separator. All standard separators are accepted. | ||
| __Diffix for Desktop__ auto-detects the CSV separator. All standard separators are accepted. | ||
|
|
||
| Diffix for Desktop auto-detects data types as text or numeric. Text columns are generalized with substring selection, and numeric columns are generalized with numeric ranges. | ||
| __Diffix for Desktop__ auto-detects data types as text or numeric. Text columns are generalized with substring selection, and numeric columns are generalized with numeric ranges. | ||
|
|
||
| After loading, Diffix for Desktop displays the column names and the first 1000 rows of the table. This data may be inspected to validate that the CSV file was loaded correctly. | ||
| After loading, __Diffix for Desktop__ displays the column names and the first 1000 rows of the table. This data may be inspected to validate that the CSV file was loaded correctly. |
Member
There was a problem hiding this comment.
These sentences sound very repetitive...
cristianberneanu
commented
Nov 2, 2021
| __Diffix for Desktop__ uses __Diffix__ as its underlying anonymization mechanism. __Diffix__ was co-developed by the __Max Planck Institute for Software Systems__ and __Aircloak GmbH__. __Diffix__ is strong enough to satisfy the GDPR definition of anonymization as non-personal data. | ||
|
|
||
| The technology is made openly available under the [__Open Diffix__](https://open-diffix.org) organization. The latest version of the mechanism is called __Diffix Elm__. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@yoid2000 Paul, is this addition ok with you?
Contributor
There was a problem hiding this comment.
I think you should remove it, because:
- Open Diffix isn't really an organization. I would call it a project, but it is really MPG that is making this available anyway.
- I was purposely not mentioning the version (Elm) because Elm includes LED-Lite, and this release doesn't include LED-Lite.
Contributor
Author
|
Merged now so I can start the release making process. Will handle Paul's comments, if any, later... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230.