Skip to content

Conversation

@cristianberneanu
Copy link
Contributor

Closes #332.

pdobacz
pdobacz previously approved these changes May 17, 2022
Copy link
Contributor

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I remember this has been a pain point. Did you double check exporting works as expected with/without generalization? I think it should be fine, but not 100% sure.

@cristianberneanu
Copy link
Contributor Author

LGTM, I remember this has been a pain point. Did you double check exporting works as expected with/without generalization? I think it should be fine, but not 100% sure.

Good point and you're right, it doesn't work because the cast to integer acts as a round, so the expression is rejected.

@cristianberneanu
Copy link
Contributor Author

Actually, that is not right, as it is a cast from text. Not sure what is happening, have to look deeper into it.

@pdobacz
Copy link
Contributor

pdobacz commented May 17, 2022

Actually, that is not right, as it is a cast from text. Not sure what is happening, have to look deeper into it.

What I recall is that the CSVDataProvider produces text for all columns, and then correct typing is up to a correct cast (based on the type inferred by the .js code) in the preview/export query.

@cristianberneanu cristianberneanu merged commit 80039f5 into master May 17, 2022
@cristianberneanu cristianberneanu deleted the cristian/misc branch May 17, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Numeric generalization of integer columns casts to real.

3 participants