Enhance editing comments in issues and PRs #50
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import OverType, { type OverTypeInstance } from 'overtype' | ||
| import type React from 'react' | ||
| import type { CommentEnhancer, CommentSpot } from '@/lib/enhancer' | ||
| import { logger } from '@/lib/logger' | ||
| import { modifyDOM } from '../modifyDOM' | ||
| import { commonGithubOptions } from './ghOptions' | ||
| import { githubHighlighter } from './githubHighlighter' | ||
|
|
||
| export interface GitHubEditCommentSpot extends CommentSpot { | ||
| type: 'GH_EDIT_COMMENT' | ||
| title: string | ||
| domain: string | ||
| slug: string | ||
| number: number | ||
| } | ||
|
|
||
| export class GitHubEditCommentEnhancer implements CommentEnhancer<GitHubEditCommentSpot> { | ||
| forSpotTypes(): string[] { | ||
| return ['GH_EDIT_COMMENT'] | ||
| } | ||
|
|
||
| tryToEnhance(_textarea: HTMLTextAreaElement): GitHubEditCommentSpot | null { | ||
| if ( | ||
| document.querySelector('meta[name="hostname"]')?.getAttribute('content') !== 'github.com' || | ||
| !_textarea.matches('.TimelineItem textarea') | ||
| ) { | ||
| return null | ||
| } | ||
|
|
||
| // Parse GitHub URL structure: /owner/repo/issues/123 or /owner/repo/pull/456 | ||
| logger.info(`${this.constructor.name} examing url`, window.location.pathname) | ||
|
|
||
| const match = window.location.pathname.match(/^\/([^/]+)\/([^/]+)(?:\/(pull|issues)\/(\d+))/) | ||
| logger.info(`${this.constructor.name} found match`, window.location.pathname) | ||
| if (!match) return null | ||
| const [, owner, repo, numberStr] = match | ||
| const slug = `${owner}/${repo}` | ||
| const number = parseInt(numberStr!, 10) | ||
| const unique_key = `github.com:${slug}:${number}` | ||
| const title = 'TODO_TITLE' | ||
| return { | ||
| domain: 'github.com', | ||
| number, | ||
| slug, | ||
| title, | ||
| type: 'GH_EDIT_COMMENT', | ||
| unique_key, | ||
| } | ||
| } | ||
|
|
||
| prepareForFirstEnhancement(): void { | ||
| OverType.setCodeHighlighter(githubHighlighter) | ||
| } | ||
|
|
||
| enhance(textArea: HTMLTextAreaElement, _spot: GitHubEditCommentSpot): OverTypeInstance { | ||
| const overtypeContainer = modifyDOM(textArea) | ||
| return new OverType(overtypeContainer, { | ||
| ...commonGithubOptions, | ||
| minHeight: '102px', | ||
| padding: 'var(--base-size-8)', | ||
| placeholder: 'Add your comment here...', | ||
| })[0]! | ||
| } | ||
|
|
||
| tableUpperDecoration(spot: GitHubEditCommentSpot): React.ReactNode { | ||
| const { slug, number } = spot | ||
| return ( | ||
| <> | ||
| <span className='font-mono text-muted-foreground text-sm'>{slug}</span> | ||
| <span className='ml-2 font-medium'>PR #{number}</span> | ||
| </> | ||
| ) | ||
| } | ||
|
|
||
| tableTitle(_spot: GitHubEditCommentSpot): string { | ||
| return 'TITLE_TODO' | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for issues, both the top and the bottom are identified as
GH_ISSUE_ADD_COMMENT. That has to get fixed.