Skip to content

Conversation

@simonlebras
Copy link
Contributor

Replaced direct property lookups like project.findProperty() and project.hasProperty() with the more modern project.getProviders().gradleProperty() API.

@nedtwigg
Copy link
Member

nedtwigg commented Nov 14, 2025

  • Use Task Providers for task initialization #2719 was merged to main, and then main merged into this
  • there are some nuisance failures around CDT, I'm considering turning off CI for that step
  • but it seems like there might be a real failure in com.diffplug.gradle.spotless.NativeCmdIntegrationTest$NativeCmdWithConfigCacheTest nativeCmd() FAILED (4.3s)
  • EDIT: I guess merging main fixed it, so not a real failure after all
Caused by: java.lang.IllegalStateException: Cannot obtain value from provider of Gradle property 'spotlessModern' at configuration time.
  Use a provider returned by 'forUseAtConfigurationTime()' instead.
  	at org.gradle.api.internal.provider.DefaultValueSourceProviderFactory$NonConfigurationTimeProvider.vetoAtConfigurationTime(DefaultValueSourceProviderFactory.java:198)
  	at org.gradle.api.internal.provider.DefaultValueSourceProviderFactory$ValueSourceProvider.calculateOwnValue(DefaultValueSourceProviderFactory.java:298)
  	at org.gradle.api.internal.provider.AbstractMinimalProvider.calculatePresence(AbstractMinimalProvider.java:79)
  	at org.gradle.api.internal.provider.AbstractMinimalProvider.isPresent(AbstractMinimalProvider.java:74)
  	at com.diffplug.gradle.spotless.GradleCompat.isPropertyPresent(GradleCompat.java:38)
  	at com.diffplug.gradle.spotless.SpotlessPlugin.apply(SpotlessPlugin.java:45)
  	at com.diffplug.gradle.spotless.SpotlessPlugin.apply(SpotlessPlugin.java:28)

@nedtwigg
Copy link
Member

@Goooler press merge on this when/if you are satisfied with it

@Goooler Goooler merged commit 8bef300 into diffplug:main Nov 15, 2025
20 checks passed
@simonlebras simonlebras deleted the gradle-property branch November 15, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants