[rewrite] fix GradleBestPractices
#2742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
pr-fix-GradleBestPractices
branch
from
13c3627 to
b4b05d4
Compare
Pankraz76
force-pushed
the
pr-fix-GradleBestPractices
branch
from
b4b05d4 to
1f3bd8c
Compare
Pankraz76
commented
Nov 19, 2025
plugin-maven/src/test/java/com/diffplug/spotless/maven/npm/NpmStepsWithNpmInstallCacheTest.java
Show resolved
Hide resolved
nedtwigg
requested changes
Nov 20, 2025
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
needs merge conflict resolution
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
pr-fix-GradleBestPractices
branch
from
1f3bd8c to
69d7d17
Compare
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
commented
Nov 20, 2025
| } | ||
|
|
||
| repositories { | ||
| mavenCentral() |
Contributor
Author
There was a problem hiding this comment.
i know spot needs this also rewrite.
Is it working without, why so?
Actually would expect mavenCentral to be kind of default best practice active by default following convention principle.
Contributor
Author
|
please if consider merge, consider squash merge or i will do if you like history kind of obsolete on this. |
nedtwigg
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)