Skip to content

Conversation

@dabeycorn
Copy link
Member

@dabeycorn dabeycorn commented Jul 21, 2025

This PR took the changes from #1 , split it into many commits, fixed some issues preventing it from running properly, got the test running properly, and updated setup.py. This would be good to merge before starting the skpkg migration.

Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
@dabeycorn dabeycorn marked this pull request as ready for review July 21, 2025 04:20
@dabeycorn
Copy link
Member Author

@sbillinge ready for review

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dabeycorn we are doing most of this work on the migration branch. @zmx27 is working on that. Please could you try and get things running using the version of pdfgetx3 on that branch so we don't bifurcate developments?

@dabeycorn
Copy link
Member Author

@sbillinge is this migration branch on a separate fork? I don't see it in this repository.

@sbillinge
Copy link
Contributor

@sbillinge is this migration branch on a separate fork? I don't see it in this repository.

type git fetch upstream and you should get it.`

Then you can do git checkout migration. If you have to make edits, make a branch off a fully synced migration (so kind of treat it like main in that way as the base branch). When you make a PR request to merge it into migration as the base branch.

@sbillinge sbillinge changed the base branch from main to migration August 13, 2025 03:19
@sbillinge sbillinge merged commit 868954f into diffpy:migration Aug 13, 2025
@sbillinge sbillinge deleted the py3 branch August 13, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants