Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
24 changes: 24 additions & 0 deletions news/build.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
**Added:**

* Add gsl to conda requirements.

**Changed:**

* Remove mac static GSL linking; always link to shared GSL.
* Change doc to docs for skpkg standard.

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* <news item>

**Security:**

* <news item>
1 change: 1 addition & 0 deletions requirements/conda.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
diffpy.structure
gsl
File renamed without changes.
16 changes: 1 addition & 15 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,7 @@ def create_extensions():
except EnvironmentError:
return []

# On macOS, dynamic linking may not be needed
if sys.platform == "darwin":
libraries = []
else:
libraries = ["gsl"]
libraries = ["gsl"]

include_dirs = [MYDIR] + gcfg["include_dirs"]
library_dirs = gcfg["library_dirs"]
Expand All @@ -180,16 +176,6 @@ def create_extensions():
"-funroll-loops",
"-ffast-math",
]
# Check for static GSL libraries and add them if found.
static_libs = [
os.path.join(p, "libgsl.a")
for p in gcfg["library_dirs"]
if os.path.isfile(os.path.join(p, "libgsl.a"))
]
if static_libs:
extra_objects += static_libs
# Use static linking: remove "-lgsl" to avoid dynamic linking conflicts.
libraries = []
elif compiler_type == "msvc":
define_macros += [("_USE_MATH_DEFINES", None)]
extra_compile_args = ["/EHs"]
Expand Down
Loading