Skip to content

Conversation

@stevenhua0320
Copy link
Contributor

@zmx27 Zhiming this is ready for review.

@stevenhua0320 stevenhua0320 changed the title fix: fix codespell, remove unused module, and fix string too long issue. style: fix codespell, remove unused module, and fix string too long issue. Oct 19, 2025
Copy link
Contributor

@zmx27 zmx27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stevenhua0320
Copy link
Contributor Author

@sbillinge Ready to review

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work here. One comment

from configparser import ConfigParser
from functools import partial

try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am gonna guess that we don't need this try except and that it is handling py2 py3 things. So let's remove it and just use the current way of doing it.

@sbillinge sbillinge merged commit d3e39e6 into diffpy:migration Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants