Støtt opprettelse av signeringsjobber med flere dokumenter #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simenstoa
commented
Oct 21, 2020
src/main/java/no/digipost/signature/client/core/SignatureJob.java
Outdated
Show resolved
Hide resolved
simenstoa
commented
Oct 21, 2020
src/main/java/no/digipost/signature/client/direct/DirectJob.java
Outdated
Show resolved
Hide resolved
simenstoa
changed the title
simenstoa
commented
Nov 4, 2020
simenstoa
force-pushed
the
multiple-documents
branch
from
3196dc0 to
8fb4822
Compare
Just single document in direct job API
Move title etc from doc to job for portal jobs
* 5.0-final: Upgrade to java-8-matchers 1.9 Upgrade dependencies Configure japicmp to support LOCAL-SNAPSHOT in pom
sarawe
changed the title
sarawe
approved these changes
Jun 9, 2021
runeflobakk
requested changes
Jun 9, 2021
runeflobakk
reviewed
Jun 9, 2021
Just to avoid unnecessary changed file in pull-request
runeflobakk
force-pushed
the
multiple-documents
branch
from
13bd455 to
30421a7
Compare
Reduce number of overloaded builder constructors: keep mainly one constructor with lists for both documents and signers, and only one additional for convenience for exactly one document and one signer. Maintaining overloaded methods with vararg variants for multiple list parameters does not scale, and it is easy to just wrap a single element in either Arrays.asList (Java 8) or List.of (Java >= 9).
Instead of requiring to be set explicitly.
Prevents name crashes when resolving filenames for creating the ASiCE document bundle.
MediaType is the proper term, formerly known as MIME type https://www.iana.org/assignments/media-types/media-types.xhtml
Autogenerate ASiCE filenames
JAXB-classes uses "mediaType" instead of "mime" digipost/signature-api-specification@5d7dcb7
A "document" is the entity encapsulating its title, type, checksum, etc, as well as its content.
Support multiple documents for jobs in API, final release
runeflobakk
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💰 Funksjonell beskrivelse av endringen
Legger til støtte for opprettelse av flere dokumenter for portaljobber.
🏆 Interessante highlights
Fjernet
getDocumentfraPortalJob, men den støttes delvis avgetDocumentiSignatureJob(returnererDocument, ikkePortalDocument). Dette er vel en breaking change, men vi skal vel uansett release en ny major versjon?🤷♀️ Anbefalt fremgangsmåte
Hele smæla på en gang?
⚙️ Avhengigheter