-
Notifications
You must be signed in to change notification settings - Fork 2
Support multiple documents #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kan denne merges til en egen "main"-branch for multiple documents? Også releaser vi internt fra den inntil den er klar for public release? Alternativt, hvis vi bare releaser internt uansett, kan vi bare release direkte fortløpende fra f.eks. denne branchen? |
1c5ffe4
to
4e160cb
Compare
Vet ikke hvordan det fungerer med interne releaser, men kan godt bare release fra denne branchen for min del. |
Previous URL resulted in 301 redirect permanently to https, but xml-maven-plugin does not seem to follow redirects. mojohaus/xml-maven-plugin#59
To have a specific type which is safer to use when passing references instead of pure Strings. XMLHref handles URL decoding/encoding in order to transparently determine equivalence between hrefs which may or may not be URL encoded.
Either a manifest has one document containing the title, nonsensitive title and description, _or_ the manifest itself specifies title, nonsensitive title and description, and has one or more documents with just a document title. Using some tricks with JAXB and private interfaces to "inject" code to be able to treat a strictly single document manifest (p.t. direct-job manifest) as a multiple documents, even though the generated JAXB-classes does not support this yet. (Reverting the cardinality of the direct-document from "unbounded" to 1) The method XMLManifest.getDocument() is appropriately marked as @deprecated, and can be replaced with the unified API for multiple documents.
…single-document-support Separate model for single and multiple documents
Test marshalling/unmarshalling roundtrip, separate into portal- and direct-flow tests.
To avoid precission loss when building on GitHib Actions.
Adds title and description to job
To be able to review API changes for generated JAXB classes.
To align with signature-api-client-java
Co-authored-by: Simen Støa <simen.stoa@bekk.no>
Co-authored-by: Simen Støa <simen.stoa@bekk.no>
Delete the SingleDocumentManifest, as it is not needed anymore, and instead have XMLDirectSignatureJobManifest implement MultipleDocumentsManifestWithLegacySingleDocumentSupport. The name just rolls off the tongue. But it allows the XMLDirectSignatureJobManifest to be consumed as a "multiple documents manifest" even though it has been unmarshalled from a legacy single document XML.
Support multiple documents for direct jobs
5554fa4
to
b937f3c
Compare
License headers in .java files is changed from Javadoc syntax, to generic multiline (non-documentation) comment.
MediaType is the proper term, formerly known as MIME type https://www.iana.org/assignments/media-types/media-types.xhtml
309dc8f
to
f78fdbb
Compare
Legger til støtte for å sende inn flere dokumenter både for portal og direktejobber. Men, om man prøver å sende inn flere dokumenter for en direktejobb får man en
FEATURE_NOT_AVAILABLE
-feil. (Det får man også for portaljobber hvis feature toggle ikke er skrudd på).Det er ikke lagt til støtte for tittel/ikke-sensitiv tittel/beskrivelse på selve jobben, dette hentes fra det første dokumentet. Om man legger på den infoen på de andre dokumentene vil de bli ignorert. Dette er tenkt løst i en egen PR før vi støtter flere dokumenter i prod.