Support multiple documents for direct jobs #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simenstoa
reviewed
Feb 2, 2021
simenstoa
reviewed
Feb 2, 2021
Co-authored-by: Simen Støa <simen.stoa@bekk.no>
Co-authored-by: Simen Støa <simen.stoa@bekk.no>
Delete the SingleDocumentManifest, as it is not needed anymore, and instead have XMLDirectSignatureJobManifest implement MultipleDocumentsManifestWithLegacySingleDocumentSupport. The name just rolls off the tongue. But it allows the XMLDirectSignatureJobManifest to be consumed as a "multiple documents manifest" even though it has been unmarshalled from a legacy single document XML.
sarawe
force-pushed
the
multiple-docs-direct-job
branch
from
19dc64c to
b6821cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legger til støtte for flere dokumenter for direkte-jobber