Skip to content

Conversation

@MaitreyaBuddha
Copy link
Contributor

@MaitreyaBuddha MaitreyaBuddha commented Oct 23, 2025

PR Type

Enhancement


Description

  • Pin Firebase CLI to version 14.19.1

  • Ensure reproducible GitHub Action builds


Diagram Walkthrough

flowchart LR
  nodeSetup["Setup Node.js v20"] -- "npm global install" --> fbTools["Install firebase-tools@14.19.1"]
  fbTools -- "verify" --> fbVersion["Run firebase --version"]
Loading

File Walkthrough

Relevant files
Enhancement
action.yml
Pin Firebase CLI version in GitHub Action                               

action.yml

  • Pin firebase-tools installation to 14.19.1.
  • Maintain Node.js setup and version check steps.
+1/-1     

@MaitreyaBuddha MaitreyaBuddha merged commit 2eff3f9 into staging Oct 23, 2025
1 of 2 checks passed
@MaitreyaBuddha MaitreyaBuddha deleted the v1.0.1 branch October 23, 2025 18:37
@github-actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Pinning Impact

Pinning firebase-tools to 14.19.1 ensures reproducibility but may block security patches or needed features; confirm this version aligns with project requirements and consider documenting/centralizing the version for easier updates.

npm install -g firebase-tools@14.19.1
firebase --version

@github-actions
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Harden install step failure handling

Add an integrity check to ensure the pinned binary installs correctly. If
installation fails, exit early to avoid running subsequent steps with a broken CLI.

action.yml [41-43]

 run: |
+  set -euo pipefail
   npm install -g firebase-tools@14.19.1
-  firebase --version
+  firebase --version || { echo "Failed to install firebase-tools@14.19.1"; exit 1; }
Suggestion importance[1-10]: 6

__

Why: The added strict shell flags and explicit failure check improve robustness of the install step. It’s contextually accurate to the new hunk, though the impact is moderate since GitHub Actions already fails on non-zero exit codes by default.

Low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants