Feature/improve UI #1007
Merged
Feature/improve UI #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshmidt-digma
requested changes
Aug 28, 2024
Comment on lines
37
to
45
| // const getAssetTypeIconColor = (theme: DefaultTheme) => { | ||
| // switch (theme.mode) { | ||
| // case "light": | ||
| // return "#788ca9"; | ||
| // case "dark": | ||
| // case "dark-jetbrains": | ||
| // return "#9c9c9c"; | ||
| // } | ||
| // }; |
Collaborator
There was a problem hiding this comment.
Seems like we do not need this code anymore
Comment on lines
90
to
93
|
|
||
| export const StyledNewIconButton = styled(NewIconButton)` | ||
| padding: 4px; | ||
| `; |
Collaborator
There was a problem hiding this comment.
No need. secondaryBorderless small button should already have this padding
| } | ||
| > | ||
| <NewIconButton | ||
| <s.StyledNewIconButton |
|
|
||
| const handleOpenDocsClick = () => { | ||
| sendUserActionTrackingEvent(trackingEvents.OPEN_DOCS_CLICKED); | ||
| openURLInDefaultBrowser("https://docs.digma.ai"); |
Collaborator
There was a problem hiding this comment.
Please add this URL to https://github.com/digma-ai/digma-ui/blob/main/src/constants.ts
kshmidt-digma
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.