Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@
"digma",
"digmathon",
"digmo",
"Hotspot",
"dont",
"hotspot",
"leaderboard",
"udemy",
"undismiss",
"zustand"
]
Expand Down
22 changes: 14 additions & 8 deletions src/components/Assets/AssetList/AssetEntry/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -145,20 +145,26 @@ export const AssetEntry = ({
<s.Stats>
<span>Performance</span>
<s.ValueContainer>
{performanceDuration ? performanceDuration.value : "N/A"}
{performanceDuration && (
<s.Suffix>{performanceDuration.unit}</s.Suffix>
{performanceDuration?.value ? (
<>
{performanceDuration.value}
<s.Suffix>{performanceDuration.unit}</s.Suffix>
</>
) : (
"N/A"
)}
</s.ValueContainer>
</s.Stats>
<s.Stats>
<span>Slowest 5%</span>
<s.ValueContainer>
{slowestFivePercentDuration
? slowestFivePercentDuration.value
: "N/A"}
{slowestFivePercentDuration && (
<s.Suffix>{slowestFivePercentDuration.unit}</s.Suffix>
{slowestFivePercentDuration?.value ? (
<>
{slowestFivePercentDuration.value}
<s.Suffix>{slowestFivePercentDuration.unit}</s.Suffix>
</>
) : (
"N/A"
)}
</s.ValueContainer>
</s.Stats>
Expand Down
15 changes: 1 addition & 14 deletions src/components/Highlights/Highlights.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { DeploymentType } from "../common/App/types";
import { mockedImpactData } from "./Impact/mockData";
import { mockedPerformanceData } from "./Performance/mockData";
import { mockedScalingData } from "./Scaling/mockData";
import { mockedSpanInfoData } from "./SpanInfo/mockData";
import { mockedTopIssuesData } from "./TopIssues/mockData";

// More on how to set up stories at: https://storybook.js.org/docs/react/writing-stories/introduction
Expand All @@ -18,9 +17,7 @@ const mockedConfig = {
...initialState,
backendInfo: {
applicationVersion:
featureFlagMinBackendVersions[
FeatureFlag.IS_HIGHLIGHTS_SPAN_INFO_ENABLED
],
featureFlagMinBackendVersions[FeatureFlag.IS_HIGHLIGHTS_SCALING_ENABLED],
deploymentType: DeploymentType.HELM,
centralize: true
}
Expand Down Expand Up @@ -57,11 +54,6 @@ export const Default: Story = {
],
play: () => {
window.setTimeout(() => {
window.postMessage({
type: "digma",
action: mainActions.SET_HIGHLIGHTS_SPAN_INFO_DATA,
payload: mockedSpanInfoData
});
window.postMessage({
type: "digma",
action: mainActions.SET_HIGHLIGHTS_TOP_ISSUES_DATA,
Expand Down Expand Up @@ -96,11 +88,6 @@ export const Empty: Story = {
],
play: () => {
window.setTimeout(() => {
window.postMessage({
type: "digma",
action: mainActions.SET_HIGHLIGHTS_SPAN_INFO_DATA,
payload: mockedSpanInfoData
});
window.postMessage({
type: "digma",
action: mainActions.SET_HIGHLIGHTS_TOP_ISSUES_DATA,
Expand Down
49 changes: 0 additions & 49 deletions src/components/Highlights/SpanInfo/SpanInfo.stories.tsx

This file was deleted.

170 changes: 0 additions & 170 deletions src/components/Highlights/SpanInfo/index.tsx

This file was deleted.

Loading