Skip to content

Added status tooltip #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Added status tooltip #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...sPage/insightCards/common/InsightCard/InsightHeader/InsightStatusTooltipContent/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ export const InsightStatusTooltipContent = ({
<TimestampKeyValue key={"first-detected"} label={"First detected"}>
{insight.firstDetected}
</TimestampKeyValue>
<TimestampKeyValue key={"last-seen"} label={"Last seen"}>
{insight.lastDetected}
</TimestampKeyValue>
<TimestampKeyValue key={"last-fixed"} label={"Last fixed"}>
{insight.lastDeactivated}
</TimestampKeyValue>
Expand Down
20 changes: 18 additions & 2 deletions ...ents/Insights/InsightsCatalog/InsightsPage/insightCards/common/IssueCompactCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,26 @@ import { MenuList } from "../../../../../../Navigation/common/MenuList";
import { MenuItem } from "../../../../../../Navigation/common/MenuList/types";
import { trackingEvents } from "../../../../../tracking";
import { isEndpointInsight, isSpanInsight } from "../../../../../typeGuards";
import { GenericCodeObjectInsight, InsightStatus } from "../../../../../types";
import { InsightIcon } from "../InsightCard/InsightHeader/InsightIcon";
import { KeyValue } from "../InsightCard/InsightHeader/InsightStatusTooltipContent/KeyValue";
import { InsightStatusTooltipContent } from "../InsightCard/InsightHeader/InsightStatusTooltipContent";
import { getInsightStatusInfo } from "../InsightStatusBadge/getInsightStatusInfo";
import * as s from "./styles";
import { IssueCompactCardProps } from "./types";

const renderInsightStatusTooltipContent = (
insight: GenericCodeObjectInsight
) => {
switch (insight.status) {
case InsightStatus.Active:
case InsightStatus.PossiblyFixed:
case InsightStatus.Regression:
return <InsightStatusTooltipContent insight={insight} />;
}

return null;
};

export const IssueCompactCard = ({
insight,
metric,
Expand Down Expand Up @@ -58,6 +72,7 @@ export const IssueCompactCard = ({
onMarkAsRead();
}
};
const statusTooltipContent = renderInsightStatusTooltipContent(insight);

const handleSpanLinkClick = () => {
sendUserActionTrackingEvent(
Expand Down Expand Up @@ -176,7 +191,8 @@ export const IssueCompactCard = ({
{metric && <Tag content={metric} type={"highlight"} />}
{insight.status && statusInfo && (
<Tooltip
title={<KeyValue label={"Status"}>{statusInfo.label}</KeyValue>}
title={statusTooltipContent}
isDisabled={!statusTooltipContent}
placement={"top"}
fullWidth={true}
>
Expand Down
Loading