Skip to content

Fixed trace navigation #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fixed trace navigation #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Insights/TopUsageInsight/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const TopUsageInsight = (props: TopUsageInsightProps) => {
const handleTraceButtonClick = (
trace: Trace,
insightType: InsightType,
spanCodeObjectId: string
spanCodeObjectId?: string
) => {
props.onTraceButtonClick(trace, insightType, spanCodeObjectId);
};
Expand Down Expand Up @@ -94,7 +94,7 @@ export const TopUsageInsight = (props: TopUsageInsightProps) => {
id: traceId
},
props.insight.type,
flow.firstService.spanCodeObjectId
props.insight.spanInfo?.spanCodeObjectId
)
}
>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Insights/TopUsageInsight/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ export interface TopUsageInsightProps extends InsightProps {
onTraceButtonClick: (
trace: Trace,
insightType: InsightType,
spanCodeObjectId: string
spanCodeObjectId?: string
) => void;
}