Skip to content

Show only single hint per insight card #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Show only single hint per insight card #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Insights/EndpointNPlusOneInsight/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const EndpointNPlusOneInsight = (
<s.ContentContainer>
<Description>Check the following locations:</Description>
<s.SpanList>
{pageItems.map((span) => {
{pageItems.map((span, i) => {
const spanInfo = span.internalSpan || span.clientSpan;
const spanName = spanInfo.displayName;
const fraction =
Expand Down Expand Up @@ -108,7 +108,7 @@ export const EndpointNPlusOneInsight = (
spanCodeObjectId={spanInfo.spanCodeObjectId}
ticketLink={span.ticketLink}
buttonType={"small"}
isHintEnabled={props.isJiraHintEnabled}
isHintEnabled={props.isJiraHintEnabled && i === 0}
/>
{config.isJaegerEnabled && (
<Tooltip title={"Trace"}>
Expand Down
4 changes: 2 additions & 2 deletions src/components/Insights/EndpointQueryOptimizationInsight/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const EndpointQueryOptimizationInsight = (
<s.ContentContainer>
<Description>Check the following locations:</Description>
<s.SpanList>
{pageItems.map((span) => {
{pageItems.map((span, i) => {
const spanInfo = span.spanInfo;
const spanName = spanInfo?.displayName;

Expand Down Expand Up @@ -94,7 +94,7 @@ export const EndpointQueryOptimizationInsight = (
spanCodeObjectId={spanInfo.spanCodeObjectId}
ticketLink={span.ticketLink}
buttonType={"small"}
isHintEnabled={props.isJiraHintEnabled}
isHintEnabled={props.isJiraHintEnabled && i === 0}
/>
{config.isJaegerEnabled && (
<Tooltip title={"Trace"}>
Expand Down
4 changes: 2 additions & 2 deletions src/components/Insights/SpanBottleneckInsight/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const SpanBottleneckInsight = (props: SpanBottleneckInsightProps) => {
</Description>
<s.Container>
<s.SpanList>
{props.insight.spans.map((span) => {
{props.insight.spans.map((span, i) => {
const spanName = span.spanInfo.displayName;
const spanCodeObjectId = span.spanInfo.spanCodeObjectId;

Expand Down Expand Up @@ -72,7 +72,7 @@ export const SpanBottleneckInsight = (props: SpanBottleneckInsightProps) => {
spanCodeObjectId={spanCodeObjectId}
ticketLink={span.ticketLink}
buttonType={"small"}
isHintEnabled={props.isJiraHintEnabled}
isHintEnabled={props.isJiraHintEnabled && i === 0}
/>
</s.ButtonsContainer>
</s.Span>
Expand Down