Skip to content

Improve card #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Improve card #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
473ddc2
Improve card
kshmidt-digma Feb 20, 2024
6316c44
Update styles
kshmidt-digma Feb 20, 2024
b77d2c7
Remove uuid
kshmidt-digma Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
"@types/react-syntax-highlighter": "^15.5.7",
"@types/react-transition-group": "^4.4.5",
"@types/semver": "^7.5.6",
"@types/uuid": "^9.0.8",
"@typescript-eslint/eslint-plugin": "^5.49.0",
"@typescript-eslint/parser": "^5.49.0",
"babel-loader": "^9.1.3",
Expand Down Expand Up @@ -121,7 +120,6 @@
"react-transition-group": "^4.4.5",
"recharts": "^2.6.2",
"semver": "^7.5.4",
"styled-components": "^6.1.0",
"uuid": "^9.0.1"
"styled-components": "^6.1.0"
}
}
1 change: 1 addition & 0 deletions src/components/Insights/BottleneckInsight/mockData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
} from "../types";

export const mockedBottleneckInsight: SpanEndpointBottleneckInsight = {
id: "60b55792-8262-4c5d-9628-1cce7979ac6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0.7,
Expand Down
1 change: 1 addition & 0 deletions src/components/Insights/DurationBreakdownInsight/DurationBreakdownInsight.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type Story = StoryObj<typeof meta>;
export const Default: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cce7979ac6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down
112 changes: 112 additions & 0 deletions src/components/Insights/DurationInsight/DurationInsight.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type Story = StoryObj<typeof meta>;
export const WithAverage: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -135,6 +136,7 @@ export const WithAverage: Story = {
export const WithChange: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cce7979ad6d",
firstDetected: null,
lastDetected: null,
criticality: 0,
Expand Down Expand Up @@ -240,6 +242,7 @@ export const WithChange: Story = {
export const WithEvaluatingChange: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cce7979ad6d",
firstDetected: null,
lastDetected: null,
criticality: 0,
Expand Down Expand Up @@ -345,6 +348,7 @@ export const WithEvaluatingChange: Story = {
export const HistogramWithManyBars: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cce7979ad6d",
firstDetected: null,
lastDetected: null,
criticality: 0,
Expand Down Expand Up @@ -4868,6 +4872,7 @@ export const HistogramWithManyBars: Story = {
export const HistogramWithGaps: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cce7979ad6d",
firstDetected: null,
lastDetected: null,
criticality: 0,
Expand Down Expand Up @@ -5121,6 +5126,7 @@ export const HistogramWithGaps: Story = {
export const HistogramWithAFewBars: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cce7979ad6d",
firstDetected: null,
lastDetected: null,
criticality: 0,
Expand Down Expand Up @@ -5269,3 +5275,109 @@ export const HistogramWithAFewBars: Story = {
}
}
};

// TODO: fix this case
export const EmptyStateBug: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cce7979ad6d",
name: "Performance Stats",
type: InsightType.SpanDurations,
category: InsightCategory.Performance,
specifity: 4,
isRecalculateEnabled: true,
spanCodeObjectId:
"span:OpenTelemetry.Instrumentation.AspNetCore$_$HTTP GET SampleInsights/HttpCall",
span: {
name: "HTTP GET SampleInsights/HttpCall",
displayName: "HTTP GET SampleInsights/HttpCall",
instrumentationLibrary: "OpenTelemetry.Instrumentation.AspNetCore",
spanCodeObjectId:
"span:OpenTelemetry.Instrumentation.AspNetCore$_$HTTP GET SampleInsights/HttpCall",
methodCodeObjectId:
"method:Sample.MoneyTransfer.API.Controllers.SampleInsightsController$_$HttpCall",
kind: "Server",
codeObjectId:
"Sample.MoneyTransfer.API.Controllers.SampleInsightsController$_$HttpCall"
},
percentiles: [
{
percentile: 0.5,
currentDuration: {
value: 426.62,
unit: "ms",
raw: 426615000
},
previousDuration: null,
changeTime: null,
changeVerified: null,
traceIds: []
},
{
percentile: 0.95,
currentDuration: {
value: 426.62,
unit: "ms",
raw: 426615000
},
previousDuration: null,
changeTime: null,
changeVerified: null,
traceIds: []
}
],
lastSpanInstanceInfo: null,
histogramPlot: null,
average: {
value: 0,
unit: "ns",
raw: 0
},
standardDeviation: {
value: 0,
unit: "ns",
raw: 0
},
isAsync: false,
scope: InsightScope.Span,
spanInfo: {
name: "HTTP GET SampleInsights/HttpCall",
displayName: "HTTP GET SampleInsights/HttpCall",
instrumentationLibrary: "OpenTelemetry.Instrumentation.AspNetCore",
spanCodeObjectId:
"span:OpenTelemetry.Instrumentation.AspNetCore$_$HTTP GET SampleInsights/HttpCall",
methodCodeObjectId:
"method:Sample.MoneyTransfer.API.Controllers.SampleInsightsController$_$HttpCall",
kind: "Server",
codeObjectId:
"Sample.MoneyTransfer.API.Controllers.SampleInsightsController$_$HttpCall"
},
shortDisplayInfo: {
title: "",
targetDisplayName: "",
subtitle: "",
description: ""
},
codeObjectId:
"Sample.MoneyTransfer.API.Controllers.SampleInsightsController$_$HttpCall",
decorators: [],
environment: "DOTNET#ID#1",
importance: 5,
severity: 0,
impact: 0,
criticality: 0,
reopenCount: 0,
ticketLink: null,
prefixedCodeObjectId:
"method:Sample.MoneyTransfer.API.Controllers.SampleInsightsController$_$HttpCall",
customStartTime: null,
actualStartTime: "0001-01-01T00:00:00",
firstCommitId: null,
lastCommitId: null,
deactivatedCommitId: null,
firstDetected: "2024-02-15T12:37:29.929835Z",
lastDetected: "2024-02-15T12:37:29.929835Z"
// flags: []
}
}
};
1 change: 1 addition & 0 deletions ...mponents/Insights/DurationSlowdownSourceInsight/DurationSlowdownSourceInsight.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type Story = StoryObj<typeof meta>;
export const WithEvaluatingChange: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-7cde7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down
1 change: 1 addition & 0 deletions src/components/Insights/EndpointNPlusOneInsight/mockData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
} from "../types";

export const mockedEndpointNPlusOneInsight: EndpointSuspectedNPlusOneInsight = {
id: "60b55792-8262-4c5d-9628-7cce7919ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down
1 change: 1 addition & 0 deletions src/components/Insights/EndpointQueryOptimizationInsight/mockData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {

export const mockedEndpointQueryOptimizationInsight: EndpointQueryOptimizationInsight =
{
id: "60b55792-8262-4c5d-9628-7cce7989ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down
1 change: 1 addition & 0 deletions src/components/Insights/ErrorsInsight/ErrorsInsight.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type Story = StoryObj<typeof meta>;
export const Default: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9628-3cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down
1 change: 1 addition & 0 deletions src/components/Insights/ExcessiveAPICallsInsight/ExcessiveAPICallsInsight.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type Story = StoryObj<typeof meta>;
export const Default: Story = {
args: {
insight: {
id: "60b55792-8262-4c5d-9688-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0.5,
Expand Down
1 change: 1 addition & 0 deletions src/components/Insights/HighNumberOfQueriesInsight/mockData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {

export const mockedHighNumberOfQueriesInsight: EndpointHighNumberOfQueriesInsight =
{
id: "60b55792-8262-4c5d-9623-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0.5,
Expand Down
1 change: 1 addition & 0 deletions src/components/Insights/InsightCard/InsightCard.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ type Story = StoryObj<typeof meta>;
export const Default: Story = {
args: {
data: {
id: "60b55792-8262-4c5d-9638-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down
1 change: 1 addition & 0 deletions src/components/Insights/InsightJiraTicket/InsightJiraTicket.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export default meta;
type Story = StoryObj<typeof meta>;

const insight = {
id: "60b55792-8262-4d5d-9628-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down
10 changes: 10 additions & 0 deletions src/components/Insights/Insights.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export const Default: Story = {
// needsObservabilityFix: false,
insights: [
{
id: "60b55792-8362-4c5d-9628-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0.8,
Expand Down Expand Up @@ -159,6 +160,7 @@ export const Default: Story = {
actualStartTime: "2023-07-27T08:23:56.500827Z"
},
{
id: "62b55792-8262-4c5d-9628-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -230,6 +232,7 @@ export const Default: Story = {
actualStartTime: "2023-06-26T00:00:00.000Z"
},
{
id: "60b55792-3262-4c5d-9628-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -284,6 +287,7 @@ export const Default: Story = {
actualStartTime: "2023-06-26T13:53:53.645Z"
},
{
id: "60b55792-4262-4c5d-9628-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -324,6 +328,7 @@ export const Default: Story = {
actualStartTime: "2023-06-26T13:53:57.956Z"
},
{
id: "60b55792-8252-4c5d-9628-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -380,6 +385,7 @@ export const Default: Story = {
actualStartTime: "2023-06-12T13:48:59.404Z"
},
{
id: "60b55792-8262-4c5d-5628-7cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -475,6 +481,7 @@ export const Default: Story = {
actualStartTime: "2023-06-12T13:49:08.186Z"
},
{
id: "60b55792-8262-4c5d-9628-6cce7979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -550,6 +557,7 @@ export const Default: Story = {
actualStartTime: "2023-06-12T13:49:03.486Z"
},
{
id: "60b55792-8262-4c5d-9628-7cce8979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -645,6 +653,7 @@ export const Default: Story = {
actualStartTime: "2023-06-13T00:00:00.000Z"
},
{
id: "60b55792-8262-4c5d-9628-7cce9979ad6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down Expand Up @@ -797,6 +806,7 @@ export const NoObservability: Story = {
};

const errorsInsight: CodeObjectErrorsInsight = {
id: "60b55792-8262-4c5d-9628-7cce7979ad1d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
Expand Down
Loading