Scaling issue #569
Merged
Scaling issue #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/Insights/common/insights/ScalingIssueInsight/index.tsx
Outdated
Show resolved
Hide resolved
| : undefined | ||
| } | ||
| onOpenHistogram={ | ||
| props.insight.spanInfo ? handleHistogramButtonClick : undefined |
Collaborator
There was a problem hiding this comment.
Suggested change
| props.insight.spanInfo ? handleHistogramButtonClick : undefined | |
| props.insight.spanInfo ? props.onHistogramButtonClick : undefined |
src/components/Insights/common/insights/ScalingIssueInsight/index.tsx
Outdated
Show resolved
Hide resolved
…dex.tsx Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com>
…dex.tsx Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com>
kshmidt-digma
approved these changes
Mar 1, 2024
kshmidt-digma
added a commit
that referenced
this pull request
Mar 5, 2024
* Fix insight types, connect new insight cards * Nplus one (#563) * Add N-Plus-One insights * Bottlneck * bottleneck * fix comments * fix comments * Add request breakdown insight * Endpoint slow down source * Add Warning icon for critical insights * Session view (#568) * Session in view --------- Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Update insight cards (#567) * Update insight cards * Scaling issue (#569) * Span scaling * Change * Update src/components/Insights/common/insights/ScalingIssueInsight/index.tsx Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Update src/components/Insights/common/insights/ScalingIssueInsight/index.tsx Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * fix warnings --------- Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Add Top Usage Insight (#571) * Add Top Usage insight * Update insight card * Query optimization (#572) * query optimization * reaname * Endpoint Query optimization * update * Update src/components/Insights/common/insights/SpanQueryOptimizationInsight/styles.ts Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * clean-up --------- Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Add Duration Breakdown insight * Update styles * custom primary button * Revert "custom primary button" This reverts commit 04a90f2. * custom primary button (#576) * custom primary button * Update src/components/Insights/common/InsightCard/index.tsx * Update src/components/Insights/common/InsightCard/index.tsx --------- Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Fix styles (#574) * Update styles * Update styles, do not trigger select opening on link click * Fix Popover * Update src/components/Insights/common/insights/ExcessiveAPICallsInsight/index.tsx * Insight update (#577) * change override for btn * Change insights * Update Endpoint Query Optimization insight card * Remove duplicated tooltips * Use state (#582) * change override for btn * Use state * fix name * Update src/components/common/App/types.ts Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Update src/components/Insights/InsightJiraTicket/index.tsx Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Update src/components/Insights/common/useInsightsData.ts Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Update src/components/Insights/InsightJiraTicket/index.tsx Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Update src/components/Insights/common/useInsightsData.ts Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Update src/components/Insights/common/useInsightsData.ts Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * fix styles * Update UI --------- Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Fix Recalculate button * Change insight buttons order, switch to criticality for icon coloring * Update toolbar icon order * Add tooltip for insight icon * Change contract for Recalculate action, small style fixes (#595) * Change contract for Recalculate action * Do not show Affected endpoinds label if list is empty * Remove Assets label in header * Update styles * Update button label * Fix env empty state (#597) * Fix empty state * fix navigation * clean-up * Update src/components/Navigation/ScopeNavigation/index.tsx * Update src/components/Navigation/ScopeNavigation/index.tsx * Update src/components/Navigation/ScopeNavigation/index.tsx * Update src/components/Navigation/ScopeNavigation/index.tsx --------- Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com> * Fix Bottleneck insights (#598) * Fix Bottleneck insights * Do not format fraction value * Fix typo * Use criticality for insight icon coloring (#599) * Use criticality for insight icon coloring * Add span link to Insight card * Fix insight card * Fix insight card header * Fix UI bugs (#601) * Fixed jira ticket ui Fixed style for trace btn * clean-up * Add description to empty Duration insight (#602) * Update styles * Update wording * Handle nullable endpoint list (#603) * Handle nullable endpoint list * Fix story * Update styles * Fix ticket open (#606) * fix types * Fix Top usage table --------- Co-authored-by: Kyrylo Shmidt <kshmidt@digma.ai> * Update src/components/Assets/AssetList/AssetEntry/AssetEntry.stories.tsx --------- Co-authored-by: opoliarush <156646693+opoliarush@users.noreply.github.com> Co-authored-by: olehp <opoliarush@digma.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.