Skip to content

Add Duration breakdown #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add Duration breakdown #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Insights/InsightsPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import { ConfigContext } from "../../common/App/ConfigContext";
import { Card } from "../../common/Card";
import { EmptyState } from "../../common/EmptyState";
import { CardsIcon } from "../../common/icons/CardsIcon";
import { DurationBreakdownInsight } from "../DurationBreakdownInsight";
import { EndpointQueryOptimizationInsight } from "../EndpointQueryOptimizationInsight";
import { actions } from "../actions";
import { DurationBreakdownInsight } from "../common/insights/DurationBreakdownInsight";
import { DurationInsight } from "../common/insights/DurationInsight";
import { EndpointBottleneckInsight } from "../common/insights/EndpointBottleneckInsight";
import { EndpointNPlusOneInsight } from "../common/insights/EndpointNPlusOneInsight";
Expand Down
366 changes: 366 additions & 0 deletions ...ts/Insights/common/insights/DurationBreakdownInsight/DurationBreakdownInsight.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,366 @@
import { Meta, StoryObj } from "@storybook/react";
import { DurationBreakdownInsight } from ".";
import { InsightCategory, InsightScope, InsightType } from "../../../types";

// More on how to set up stories at: https://storybook.js.org/docs/react/writing-stories/introduction
const meta: Meta<typeof DurationBreakdownInsight> = {
title: "Insights/common/insights/DurationBreakdownInsight",
component: DurationBreakdownInsight,
parameters: {
// More on how to position stories at: https://storybook.js.org/docs/react/configure/story-layout
layout: "fullscreen"
}
};

export default meta;

type Story = StoryObj<typeof meta>;

export const Default: Story = {
args: {
insight: {
sourceSpanCodeObjectInsight: "sourceSpanCodeObjectInsightId",
id: "60b55792-8262-4c5d-9628-7cce7979ac6d",
firstDetected: "2023-12-05T17:25:47.010Z",
lastDetected: "2024-01-05T13:14:47.010Z",
criticality: 0,
firstCommitId: "b3f7b3f",
lastCommitId: "a1b2c3d",
deactivatedCommitId: null,
reopenCount: 0,
ticketLink: null,
impact: 0,
name: "Span Duration Breakdown",
type: InsightType.SpanDurationBreakdown,
category: InsightCategory.Performance,
specifity: 4,
isRecalculateEnabled: true,
importance: 6,
spanName: "ClientTester.generateInsightData",
spanCodeObjectId:
"span:io.opentelemetry.opentelemetry-instrumentation-annotations-1.16$_$ClientTester.generateInsightData",
breakdownEntries: [
{
spanName: "GET PetClinic /SampleInsights/ErrorHotspot",
spanDisplayName: "GET PetClinic /SampleInsights/ErrorHotspot",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/ErrorHotspot",
percentiles: [
{
percentile: 0.5,
duration: {
value: 9.31,
unit: "ms",
raw: 9310166
}
},
{
percentile: 0.95,
duration: {
value: 9.31,
unit: "ms",
raw: 9310166
}
}
],
codeObjectId: null
},
{
spanName: "GET PetClinic /SampleInsights/ErrorRecordedOnCurrentSpan",
spanDisplayName:
"GET PetClinic /SampleInsights/ErrorRecordedOnCurrentSpan",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/ErrorRecordedOnCurrentSpan",
percentiles: [
{
percentile: 0.5,
duration: {
value: 1.85,
unit: "ms",
raw: 1853959
}
},
{
percentile: 0.95,
duration: {
value: 1.85,
unit: "ms",
raw: 1853959
}
}
],
codeObjectId: null
},
{
spanName:
"GET PetClinic /SampleInsights/ErrorRecordedOnDeeplyNestedSpan",
spanDisplayName:
"GET PetClinic /SampleInsights/ErrorRecordedOnDeeplyNestedSpan",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/ErrorRecordedOnDeeplyNestedSpan",
percentiles: [
{
percentile: 0.5,
duration: {
value: 2.98,
unit: "ms",
raw: 2977875
}
},
{
percentile: 0.95,
duration: {
value: 2.98,
unit: "ms",
raw: 2977875
}
}
],
codeObjectId: null
},
{
spanName:
"GET PetClinic /SampleInsights/ErrorRecordedOnLocalRootSpan",
spanDisplayName:
"GET PetClinic /SampleInsights/ErrorRecordedOnLocalRootSpan",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/ErrorRecordedOnLocalRootSpan",
percentiles: [
{
percentile: 0.5,
duration: {
value: 18.64,
unit: "ms",
raw: 18642667
}
},
{
percentile: 0.95,
duration: {
value: 18.64,
unit: "ms",
raw: 18642667
}
}
],
codeObjectId: null
},
{
spanName: "GET PetClinic /SampleInsights/HighUsage",
spanDisplayName: "GET PetClinic /SampleInsights/HighUsage",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/HighUsage",
percentiles: [
{
percentile: 0.5,
duration: {
value: 1.28,
unit: "sec",
raw: 1276017342
}
},
{
percentile: 0.95,
duration: {
value: 1.88,
unit: "sec",
raw: 1883717142
}
}
],
codeObjectId: null
},
{
spanName: "GET PetClinic /SampleInsights/NPlusOneWithInternalSpan",
spanDisplayName:
"GET PetClinic /SampleInsights/NPlusOneWithInternalSpan",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/NPlusOneWithInternalSpan",
percentiles: [
{
percentile: 0.5,
duration: {
value: 8.62,
unit: "ms",
raw: 8622375
}
},
{
percentile: 0.95,
duration: {
value: 8.62,
unit: "ms",
raw: 8622375
}
}
],
codeObjectId: null
},
{
spanName: "GET PetClinic /SampleInsights/NPlusOneWithoutInternalSpan",
spanDisplayName:
"GET PetClinic /SampleInsights/NPlusOneWithoutInternalSpan",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/NPlusOneWithoutInternalSpan",
percentiles: [
{
percentile: 0.5,
duration: {
value: 2.95,
unit: "ms",
raw: 2951917
}
},
{
percentile: 0.95,
duration: {
value: 2.95,
unit: "ms",
raw: 2951917
}
}
],
codeObjectId: null
},
{
spanName: "GET PetClinic /SampleInsights/SlowEndpoint",
spanDisplayName: "GET PetClinic /SampleInsights/SlowEndpoint",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/SlowEndpoint",
percentiles: [
{
percentile: 0.5,
duration: {
value: 5.01,
unit: "sec",
raw: 5011033127
}
},
{
percentile: 0.95,
duration: {
value: 5.01,
unit: "sec",
raw: 5011033127
}
}
],
codeObjectId: null
},
{
spanName: "GET PetClinic /SampleInsights/SpanBottleneck",
spanDisplayName: "GET PetClinic /SampleInsights/SpanBottleneck",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/SpanBottleneck",
percentiles: [
{
percentile: 0.5,
duration: {
value: 520.92,
unit: "ms",
raw: 520920000
}
},
{
percentile: 0.95,
duration: {
value: 520.92,
unit: "ms",
raw: 520920000
}
}
],
codeObjectId: null
},
{
spanName: "GET PetClinic /SampleInsights/req-map-get",
spanDisplayName: "GET PetClinic /SampleInsights/req-map-get",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$GET PetClinic /SampleInsights/req-map-get",
percentiles: [
{
percentile: 0.5,
duration: {
value: 1.56,
unit: "ms",
raw: 1556959
}
},
{
percentile: 0.95,
duration: {
value: 1.56,
unit: "ms",
raw: 1556959
}
}
],
codeObjectId: null
},
{
spanName: "HTTP GET ClientTester.generateInsightData",
spanDisplayName: "HTTP GET ClientTester.generateInsightData",
spanInstrumentationLibrary: "io.opentelemetry.okhttp-3.0",
spanCodeObjectId:
"span:io.opentelemetry.okhttp-3.0$_$HTTP GET ClientTester.generateInsightData",
percentiles: [
{
percentile: 0.5,
duration: {
value: 693.35,
unit: "ms",
raw: 693349003
}
},
{
percentile: 0.95,
duration: {
value: 693.35,
unit: "ms",
raw: 693349003
}
}
],
codeObjectId: null
}
],
scope: InsightScope.Span,
spanInfo: {
name: "ClientTester.generateInsightData",
displayName: "ClientTester.generateInsightData",
instrumentationLibrary:
"io.opentelemetry.opentelemetry-instrumentation-annotations-1.16",
spanCodeObjectId:
"span:io.opentelemetry.opentelemetry-instrumentation-annotations-1.16$_$ClientTester.generateInsightData",
methodCodeObjectId:
"method:petclinic.client.ClientTester$_$generateInsightData",
kind: "Internal",
codeObjectId: "petclinic.client.ClientTester$_$generateInsightData"
},
shortDisplayInfo: {
title: "",
targetDisplayName: "",
subtitle: "",
description: ""
},
codeObjectId: "petclinic.client.ClientTester$_$generateInsightData",
decorators: null,
environment: "SAMPLE_ENV",
severity: 0,
prefixedCodeObjectId:
"method:petclinic.client.ClientTester$_$generateInsightData",
customStartTime: null,
actualStartTime: "2023-06-16T10:30:31.848Z"
}
}
};
Loading