Skip to content

Add span link to Insight card #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add span link to Insight card #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a9dd2a
Add span link to Insight card
kshmidt-digma Mar 4, 2024
9f6f6a1
Fix insight card
kshmidt-digma Mar 4, 2024
d96dbc4
Fix insight card header
kshmidt-digma Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/components/Insights/InsightList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { useEffect, useState } from "react";
import { DefaultTheme, useTheme } from "styled-components";
import { actions as globalActions } from "../../../actions";
import { usePersistence } from "../../../hooks/usePersistence";
import { trackingEvents as globalTrackingEvents } from "../../../trackingEvents";
import { isUndefined } from "../../../typeGuards/isUndefined";
import { InsightType } from "../../../types";
import { getInsightTypeInfo } from "../../../utils/getInsightTypeInfo";
import { getInsightTypeOrderPriority } from "../../../utils/getInsightTypeOrderPriority";
import { sendTrackingEvent } from "../../../utils/sendTrackingEvent";
import { ChangeScopePayload } from "../../Navigation/types";
import { Card } from "../../common/Card";
import { Tooltip } from "../../common/Tooltip";
import { EndpointIcon } from "../../common/icons/EndpointIcon";
Expand Down Expand Up @@ -338,6 +340,17 @@ const renderInsightCard = (
});
};

const handleGoToSpan = (spanCodeObjectId: string) => {
window.sendMessageToDigma<ChangeScopePayload>({
action: globalActions.CHANGE_SCOPE,
payload: {
span: {
spanCodeObjectId
}
}
});
};

if (isSpanDurationsInsight(insight)) {
return (
<DurationInsight
Expand All @@ -348,6 +361,7 @@ const renderInsightCard = (
onCompareButtonClick={handleCompareButtonClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -359,6 +373,7 @@ const renderInsightCard = (
onAssetLinkClick={handleAssetLinkClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -371,6 +386,7 @@ const renderInsightCard = (
onTraceButtonClick={handleTraceButtonClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -384,6 +400,7 @@ const renderInsightCard = (
onRefresh={handleRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -397,6 +414,7 @@ const renderInsightCard = (
onRefresh={handleRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -407,6 +425,7 @@ const renderInsightCard = (
insight={insight}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -421,6 +440,7 @@ const renderInsightCard = (
insight={insight}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -433,6 +453,7 @@ const renderInsightCard = (
onExpandButtonClick={handleErrorsExpandButtonClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -447,6 +468,7 @@ const renderInsightCard = (
onRefresh={handleRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -461,6 +483,7 @@ const renderInsightCard = (
onRefresh={handleRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -476,6 +499,7 @@ const renderInsightCard = (
onRefresh={handleRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -502,6 +526,7 @@ const renderInsightCard = (
onAssetLinkClick={handleAssetLinkClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -513,6 +538,7 @@ const renderInsightCard = (
insight={insight}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -525,6 +551,7 @@ const renderInsightCard = (
onHistogramButtonClick={handleHistogramButtonClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -537,6 +564,7 @@ const renderInsightCard = (
onHistogramButtonClick={handleHistogramButtonClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -550,6 +578,7 @@ const renderInsightCard = (
onTraceButtonClick={handleTraceButtonClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -563,6 +592,7 @@ const renderInsightCard = (
onTraceButtonClick={handleTraceButtonClick}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -577,6 +607,7 @@ const renderInsightCard = (
onRefresh={handleRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -588,6 +619,7 @@ const renderInsightCard = (
insight={insight}
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -603,6 +635,7 @@ const renderInsightCard = (
onRefresh={handleRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -617,6 +650,7 @@ const renderInsightCard = (
onRecalculate={handleRecalculate}
onRefresh={handleRefresh}
onJiraTicketCreate={onJiraTicketCreate}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand Down
30 changes: 30 additions & 0 deletions src/components/Insights/InsightsPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { isNumber } from "../../../typeGuards/isNumber";
import { isUndefined } from "../../../typeGuards/isUndefined";
import { InsightType } from "../../../types";
import { sendTrackingEvent } from "../../../utils/sendTrackingEvent";
import { ChangeScopePayload } from "../../Navigation/types";
import { ConfigContext } from "../../common/App/ConfigContext";
import { Card } from "../../common/Card";
import { EmptyState } from "../../common/EmptyState";
Expand Down Expand Up @@ -186,6 +187,17 @@ const renderInsightCard = (
});
};

const handleGoToSpan = (spanCodeObjectId: string) => {
window.sendMessageToDigma<ChangeScopePayload>({
action: globalActions.CHANGE_SCOPE,
payload: {
span: {
spanCodeObjectId
}
}
});
};

if (isSpanDurationsInsight(insight)) {
return (
<DurationInsight
Expand All @@ -196,6 +208,7 @@ const renderInsightCard = (
onCompareButtonClick={handleCompareButtonClick}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -208,6 +221,7 @@ const renderInsightCard = (
onAssetLinkClick={handleAssetLinkClick}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -221,6 +235,7 @@ const renderInsightCard = (
onTraceButtonClick={handleTraceButtonClick}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -235,6 +250,7 @@ const renderInsightCard = (
onRefresh={onRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -249,6 +265,7 @@ const renderInsightCard = (
onRefresh={onRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -260,6 +277,7 @@ const renderInsightCard = (
insight={insight}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -275,6 +293,7 @@ const renderInsightCard = (
insight={insight}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -290,6 +309,7 @@ const renderInsightCard = (
onRefresh={onRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -305,6 +325,7 @@ const renderInsightCard = (
onRefresh={onRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -321,6 +342,7 @@ const renderInsightCard = (
onRefresh={onRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -333,6 +355,7 @@ const renderInsightCard = (
onAssetLinkClick={handleAssetLinkClick}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -344,6 +367,7 @@ const renderInsightCard = (
insight={insight}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -357,6 +381,7 @@ const renderInsightCard = (
onTraceButtonClick={handleTraceButtonClick}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -370,6 +395,7 @@ const renderInsightCard = (
onTraceButtonClick={handleTraceButtonClick}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -384,6 +410,7 @@ const renderInsightCard = (
onRefresh={onRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -395,6 +422,7 @@ const renderInsightCard = (
insight={insight}
onRecalculate={handleRecalculate}
onRefresh={onRefresh}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -410,6 +438,7 @@ const renderInsightCard = (
onRefresh={onRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand All @@ -425,6 +454,7 @@ const renderInsightCard = (
onRefresh={onRefresh}
onJiraTicketCreate={onJiraTicketCreate}
isJiraHintEnabled={isJiraHintEnabled}
onGoToSpan={handleGoToSpan}
/>
);
}
Expand Down
Loading