Skip to content

Update Bottleneck insights description #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Update Bottleneck insights description #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/components/Insights/common/insights/EndpointBottleneckInsight/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,25 @@ export const EndpointBottleneckInsight = (
/>
</Details>
<ColumnsContainer>
<KeyValue label={"% of Duration"}>
<KeyValue
label={
<Info
text={
"The percentage of the overall request time taken up by this bottleneck asset"
}
name={"% of Duration"}
/>
}
>
{span.avgFractionWhenBeingBottleneck}%
</KeyValue>
<KeyValue
label={
<Info
text={"Percentage of request consumed by the bottleneck span"}
name={"% of Request"}
text={
"The percentage of requests for the selected endpoint experiencing this bottleneck"
}
name={"% of Requests"}
/>
}
>
Expand Down
15 changes: 12 additions & 3 deletions src/components/Insights/common/insights/SpanEndpointBottleneckInsight/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,25 @@ export const SpanEndpointBottleneckInsight = (
</Details>
{selectedEndpoint && (
<ColumnsContainer>
<KeyValue label={"% of Duration"}>
<KeyValue
label={
<Info
text={
"The percentage of the overall request time taken up by this bottleneck asset"
}
name={"% of Duration"}
/>
}
>
{selectedEndpoint.avgFractionWhenBeingBottleneck}%
</KeyValue>
<KeyValue
label={
<Info
text={
"Percentage of request consumed by the bottleneck span"
"The percentage of requests for the selected endpoint experiencing this bottleneck"
}
name={"% of Request"}
name={"% of Requests"}
/>
}
>
Expand Down