Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
import { Meta, StoryObj } from "@storybook/react";
import { EnvironmentSelector } from ".";

// More on how to set up stories at: https://storybook.js.org/docs/react/writing-stories/introduction
const meta: Meta<typeof EnvironmentSelector> = {
title: "Insights/InsightsCatalog/EnvironmentSelector",
component: EnvironmentSelector,
parameters: {
// More on how to position stories at: https://storybook.js.org/docs/react/configure/story-layout
layout: "fullscreen"
}
};

export default meta;

type Story = StoryObj<typeof meta>;

export const Default: Story = {
args: {
environments: [
{
environment: {
id: "1",
name: "Production",
type: "Public"
},
issueCounts: {
highCriticality: 5,
mediumCriticality: 3,
lowCriticality: 1
}
},
{
environment: {
id: "2",
name: "Staging",
type: "Public"
},
issueCounts: {
highCriticality: 2,
mediumCriticality: 4,
lowCriticality: 0
}
},
{
environment: {
id: "3",
name: "Development",
type: "Public"
},
issueCounts: {
highCriticality: 0,
mediumCriticality: 1,
lowCriticality: 2
}
},
{
environment: {
id: "4",
name: "Without Issues",
type: "Public"
},
issueCounts: {
highCriticality: 0,
mediumCriticality: 0,
lowCriticality: 0
}
}
]
}
};
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const SpaNPlusOneInsightCard = ({
id: selectedEndpoint.traceId
},
insight.type,
selectedEndpoint.endpointInfo.spanCodeObjectId
insight.spanInfo?.spanCodeObjectId
)
}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export const SpanEndpointBottleneckInsightCard = ({
id: selectedEndpoint.traceId
},
insight.type,
selectedEndpoint.endpointInfo.spanCodeObjectId
insight.spanInfo?.spanCodeObjectId
);
}}
/>
Expand Down
36 changes: 18 additions & 18 deletions src/components/Insights/Issues/IssuesFilter/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,24 @@ export const IssuesFilter = () => {
<CrossIcon color={"currentColor"} size={16} />
</s.CloseButton>
</s.Header>
{isServicesFilterEnabled && (
<>
<s.FilterCategoryName>Services</s.FilterCategoryName>
<Select
key={"services"}
items={servicesFilterOptions}
onChange={handleServiceChange}
placeholder={filteredServices.length > 0 ? "Services" : "All"}
multiselect={true}
icon={(props: IconProps) => (
<s.InsightIconContainer>
<WrenchIcon {...props} />
</s.InsightIconContainer>
)}
disabled={issueTypesFilterOptions?.length === 0}
/>
</>
)}
<s.FilterCategoryName>Issues</s.FilterCategoryName>
<Select
key={"issues"}
Expand Down Expand Up @@ -239,24 +257,6 @@ export const IssuesFilter = () => {
)}
showSelectedState={isUnreadOnly}
/>
{isServicesFilterEnabled && (
<>
<s.FilterCategoryName>Services</s.FilterCategoryName>
<Select
key={"services"}
items={servicesFilterOptions}
onChange={handleServiceChange}
placeholder={filteredServices.length > 0 ? "Services" : "All"}
multiselect={true}
icon={(props: IconProps) => (
<s.InsightIconContainer>
<WrenchIcon {...props} />
</s.InsightIconContainer>
)}
disabled={issueTypesFilterOptions?.length === 0}
/>
</>
)}
<s.Footer>
<s.ClearAllButton
buttonType={"tertiary"}
Expand Down