Skip to content

Add Endpoint Duration Slowdown insight support #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Add Endpoint Duration Slowdown insight support #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
623839e
Add Endpoint Duration Slowdown insight
kshmidt-digma May 31, 2023
f5ea301
Sort insights by order priority
kshmidt-digma May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { actions } from '../../../../api/digma/actions';
import { dispatcher } from '../../../../api/digma/dispatcher';
import { state as globalState } from '../../../../api/digma/state';
import { ISpanInsight, SetSpansDataPayload } from '../../../../api/digma/types';
import { getInsightTypeInfo } from '../../../common/InsightIcon/utils';
import { getInsightTypeInfo, getInsightTypeOrderPriority } from '../../../common/InsightIcon/utils';
import { InsightIcon } from '../../../common/InsightIcon';
import Button from '../../../common/Button';
import { CrosshairIcon } from '../../../common/icons/CrosshairIcon';
Expand Down Expand Up @@ -80,7 +80,11 @@ export default class SpanDetail extends React.Component<SpanDetailProps, SpanDet
}

_sortInsightsByImportance(insights: ISpanInsight[]): ISpanInsight[] {
return [...insights].sort((a, b) => a.importance - b.importance);
return [...insights].sort(
(a, b) =>
a.importance - b.importance ||
getInsightTypeOrderPriority(a.type) - getInsightTypeOrderPriority(b.type)
);
}

_updateSpanInfo(data: unknown) {
Expand Down
1 change: 1 addition & 0 deletions packages/jaeger-ui/src/components/common/InsightIcon/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,5 @@ export enum InsightType {
SpanScaling = 'SpanScaling',
SpanScalingRootCause = 'SpanScalingRootCause',
SpanDurationBreakdown = 'SpanDurationBreakdown',
EndpointDurationSlowdown = 'EndpointDurationSlowdown',
}
30 changes: 30 additions & 0 deletions packages/jaeger-ui/src/components/common/InsightIcon/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ export const getInsightTypeInfo = (
icon: ClockWithTicksIcon,
label: 'Duration Breakdown',
},
[InsightType.EndpointDurationSlowdown]: {
icon: SnailIcon,
label: 'Duration Slowdown Source Detected',
},
};

return insightInfoMap[type];
Expand All @@ -110,3 +114,29 @@ export const getInsightImportanceColor = (importance: number): string | undefine

return '#1dc693';
};

export const getInsightTypeOrderPriority = (type: string): number => {
const insightOrderPriorityMap: Record<string, number> = {
[InsightType.HotSpot]: 1,
[InsightType.Errors]: 2,
[InsightType.TopErrorFlows]: 3,

[InsightType.SpanDurations]: 60,
[InsightType.SpanUsages]: 61,
[InsightType.SpanScaling]: 63,
[InsightType.SpanNPlusOne]: 65,
[InsightType.SpanDurationChange]: 66,
[InsightType.SpanEndpointBottleneck]: 67,
[InsightType.SpanDurationBreakdown]: 68,

[InsightType.EndpointSpanNPlusOne]: 55,
[InsightType.SlowestSpans]: 40,
[InsightType.LowUsage]: 30,
[InsightType.NormalUsage]: 50,
[InsightType.HighUsage]: 10,
[InsightType.SlowEndpoint]: 20,
[InsightType.EndpointDurationSlowdown]: 25,
};

return insightOrderPriorityMap[type] || Infinity;
};