Skip to content

Conversation

@wilfwilson
Copy link
Collaborator

@wilfwilson wilfwilson commented Oct 29, 2021

These files are auto-generated by GAPDoc when compiling the manual. The files are copied from the current version of GAPDoc.

The contents of doc/manual.js has recently changed in the master branch of GAPDoc (and therefore in future branches). The new version fixes a bug that existed in the old version.

This therefore means that there may be a mismatch between the installed GAPDoc version, and the version of that file that exists in the repository. For me, this means that every time I recompile the manual, I have to run git checkout doc/manual.js to remove the change (and revert to a buggy version of doc/manual.js).

This is annoying.

To resolve this and similar issues, the easiest thing to do is just to remove these files from the repository.

@wilfwilson wilfwilson added minor A label for PRs or issues that are minor in some sense. doc Issues, bugs, pull requests relating to the documentation bugfix A label for PRs that fix a bug technical A necessary technical change, not interesting mathematically/feature-wise labels Oct 29, 2021
These files are auto-generated by GAPDoc when compiling the manual.
The files are copied from the current version of GAPDoc.

The contents of doc/manual.js has recently changed in the master branch
of GAPDoc (and therefore in future branches). The new version fixes a
bug that existed in the old version.

This therefore means that there may be a mismatch between the installed
GAPDoc version, and the version of that file that exists in the repository.
For me, this means that every time I recompile the manual, I have to
run `git checkout doc/manual.js` to remove the change.

This is annoying.

To resolve this and similar issues, the easiest thing to do is just to
remove these files from the repository.

Almost removes doc/chooser.html
@wilfwilson wilfwilson changed the title Remove doc/*.js and doc/*.css from the repo Remove doc/*.js, doc/*.css, doc/chooser.html from the repo Oct 29, 2021
@wilfwilson wilfwilson merged commit 4b4d860 into digraphs:stable-1.5 Nov 3, 2021
@wilfwilson wilfwilson deleted the remove-doc-js-css branch November 3, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A label for PRs that fix a bug doc Issues, bugs, pull requests relating to the documentation minor A label for PRs or issues that are minor in some sense. technical A necessary technical change, not interesting mathematically/feature-wise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant