Fix issues in cryptography_flutter #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
terrier989
November 20, 2025 20:26
terrier989
force-pushed
the
fix/cryptography_flutter
branch
from
b869b7f to
448f6ff
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the cryptography_flutter plugin by migrating to newer Flutter tooling, updating dependencies, and improving test coverage. The changes primarily focus on removing deprecated platform support (Windows, Web, Linux), migrating iOS/macOS from CocoaPods to Swift Package Manager, and enhancing Ed25519 test coverage to handle platform-specific behavior.
Key changes:
- Migrated iOS/macOS from CocoaPods to Swift Package Manager with privacy manifests
- Improved Ed25519 test organization to handle iOS randomized signatures
- Updated dependency ranges to support older Flutter SDKs
- Removed Windows, Web, and Linux platform files
- Updated Android build configuration to modern Gradle/Kotlin versions
Reviewed Changes
Copilot reviewed 153 out of 175 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cryptography_test/lib/algorithms/hkdf.dart | Removed unused import |
| cryptography_test/lib/algorithms/ed25519.dart | Split test into platform-specific cases for iOS randomized signatures |
| cryptography_flutter/pubspec.yaml | Expanded flutter_lints version range for SDK compatibility |
| cryptography_flutter_integration_test/pubspec.yaml | Expanded flutter_lints version range for SDK compatibility |
| cryptography_flutter/ios/cryptography_flutter.podspec | Updated podspec for SPM migration |
| cryptography_flutter/macos/cryptography_flutter.podspec | Updated podspec for SPM migration |
| cryptography_flutter_integration_test/android/settings.gradle.kts | Migrated to Kotlin DSL build configuration |
| cryptography_flutter_integration_test/tool/test.sh | Added test automation script |
| Multiple iOS/macOS files | Removed CocoaPods files, added SPM Package.swift and privacy manifests |
| Multiple Windows/Web/Linux files | Removed platform support files |
| Multiple Android files | Updated to modern Gradle 8.14 and Kotlin 2.2.20 |
Files not reviewed (4)
- cryptography_flutter/example/ios/Runner.xcworkspace/contents.xcworkspacedata: Language not supported
- cryptography_flutter/example/macos/Runner.xcworkspace/contents.xcworkspacedata: Language not supported
- cryptography_flutter_integration_test/ios/Runner.xcworkspace/contents.xcworkspacedata: Language not supported
- cryptography_flutter_integration_test/macos/Runner.xcworkspace/contents.xcworkspacedata: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
terrier989
force-pushed
the
fix/cryptography_flutter
branch
5 times, most recently
from
6f7cd4f to
621c317
Compare
terrier989
force-pushed
the
fix/cryptography_flutter
branch
from
621c317 to
ca2d6dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the cryptography_flutter plugin by migrating to newer Flutter tooling and updating dependencies.