[BOARD] configurable with enum #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilles
approved these changes
Oct 22, 2025
akhilles
reviewed
Oct 22, 2025
board_config.zen
Outdated
| 4: BASE_4L_STACKUP, | ||
| 6: BASE_6L_STACKUP, | ||
| 8: BASE_8L_STACKUP, | ||
| }.get(layers) |
There was a problem hiding this comment.
if outer_copper_weight is 2oz, we should choose the 2oz stackups here.
There was a problem hiding this comment.
we only have a 4L_2OZ, added and explained we should add the other ones
board_config.zen
Outdated
| 4: BASE_4L_NETCLASSES, | ||
| 6: BASE_6L_NETCLASSES, | ||
| 8: BASE_8L_NETCLASSES, | ||
| }.get(layers) |
There was a problem hiding this comment.
same here, we should choose the 2oz base netclasses if outer_copper_weight is 2oz
There was a problem hiding this comment.
added, but only for 4L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.