Fix: possible off-by-1 error #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the big maps are all in the same level, using `i + 1` at the end when passing the tuple is missing the last member because i stops at `len - 1`. A 16 length big map event was returning 0 - 14 instead of 0 - 15. I just added 1 in the final case and it fixed the issue on my end. I'm not sure if there are any side-effects here.
Collaborator
|
Thank you! I will refactor this class someday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the big maps are all in the same level, using
i + 1at the end when passing the tuple is missing the last member because it stops atlen - 1. A 16 length big map event was returning members 0 - 14 instead of 0 - 15.I just added 1 in the final case and it fixed the issue on my end. I'm not sure if there are any side-effects here.