fix: don't always clone properties in pickNonSpecialProps

Author: Akryum

packages/core/src/mutation/create.ts

@@ -28,7 +28,7 @@ export async function createItem<
 
   const originalItem = item
 
-  item = pickNonSpecialProps(item) as Partial<ResolvedModelItem<TModel, TModelDefaults, TSchema>>
+  item = pickNonSpecialProps(item, true) as Partial<ResolvedModelItem<TModel, TModelDefaults, TSchema>>
 
   store.$processItemSerialization(model, item)
 

packages/core/src/mutation/update.ts

@@ -31,7 +31,7 @@ export async function updateItem<
 
   const originalItem = item
 
-  item = pickNonSpecialProps(item) as Partial<ResolvedModelItem<TModel, TModelDefaults, TSchema>>
+  item = pickNonSpecialProps(item, true) as Partial<ResolvedModelItem<TModel, TModelDefaults, TSchema>>
 
   key = key ?? model.getKey(item)
 

packages/shared/src/utils/obj.ts

@@ -25,21 +25,21 @@ export function set<TObject, TPath extends Path<TObject>>(obj: TObject, path: TP
   current[keys.at(-1)!] = value
 }
 
-export function pickNonSpecialProps<TItem extends Record<string, any>>(item: TItem): Pick<TItem, FilterNotStartingWith<keyof TItem, '$'>> {
+export function pickNonSpecialProps<TItem extends Record<string, any>>(item: TItem, clone = false): Pick<TItem, FilterNotStartingWith<keyof TItem, '$'>> {
   const result: any = {}
   for (const key in item) {
     if (!key.startsWith('$')) {
-      result[key] = klona(item[key])
+      result[key] = clone ? klona(item[key]) : item[key]
     }
   }
   return result
 }
 
-export function pickSpecialProps<TItem extends Record<string, any>>(item: TItem): Pick<TItem, FilterStartsWith<keyof TItem, '$'>> {
+export function pickSpecialProps<TItem extends Record<string, any>>(item: TItem, clone = false): Pick<TItem, FilterStartsWith<keyof TItem, '$'>> {
   const result: any = {}
   for (const key in item) {
     if (key.startsWith('$')) {
-      result[key] = klona(item[key])
+      result[key] = clone ? klona(item[key]) : item[key]
     }
   }
   return result

packages/vue/src/api.ts

@@ -472,7 +472,7 @@ export function createModelApi<
           throw new Error('Item not found')
         }
 
-        return pickNonSpecialProps(item)
+        return pickNonSpecialProps(item, true)
       }
 
       const initialData = await getFormData()

packages/vue/src/cache.ts

@@ -188,7 +188,7 @@ export function createCache<
     writeItem({ model, key, item, marker, fromWriteItems }) {
       state.value[model.name] ??= {}
       const itemsForType = state.value[model.name]
-      const rawData = pickNonSpecialProps(item)
+      const rawData = pickNonSpecialProps(item, true)
 
       // Handle relations
       const data = {} as Record<string, any>

packages/vue/src/form.ts

@@ -67,7 +67,7 @@ export function createFormObject<
   TSchema extends StandardSchemaV1 = StandardSchemaV1,
   const TAdditionalProps = Record<string, never>,
 >(options: CreateFormObjectOptions<TData, TSchema, TAdditionalProps>) {
-  let initialData = pickNonSpecialProps(options.defaultValues?.() ?? {}) as Partial<TData>
+  let initialData = pickNonSpecialProps(options.defaultValues?.() ?? {}, true) as Partial<TData>
 
   const onSuccess = createEventHook()
   const onError = createEventHook<Error>()
@@ -88,18 +88,18 @@ export function createFormObject<
       }
       if (options.resetDefaultValues) {
         const values = await options.resetDefaultValues()
-        initialData = pickNonSpecialProps(values) as Partial<TData>
+        initialData = pickNonSpecialProps(values, true) as Partial<TData>
       }
       else if (options.defaultValues) {
-        initialData = pickNonSpecialProps(options.defaultValues()) as Partial<TData>
+        initialData = pickNonSpecialProps(options.defaultValues(), true) as Partial<TData>
       }
       Object.assign(form, initialData)
     },
     async $submit() {
       form.$loading = true
       form.$error = null
       try {
-        const data = options?.transformData ? options.transformData(form as unknown as Partial<TData>) : pickNonSpecialProps(form) as Partial<TData>
+        const data = options?.transformData ? options.transformData(form as unknown as Partial<TData>) : pickNonSpecialProps(form, true) as Partial<TData>
         const { issues } = await this.$schema['~standard'].validate(data)
         if (issues) {
           const error = new Error(issues.map(i => i.message).join(', '))